[GitHub] flink pull request #2172: [FLINK-4096] Ensure JarOutputStream is always clos...

[zentol <gi...@git.apache.org>]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2172#discussion_r69295166
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/JarFileCreator.java ---
    @@ -189,33 +189,33 @@ public synchronized void createJarFile() throws IOException {
     			this.outputFile.delete();
     		}
     
    -		final JarOutputStream jos = new JarOutputStream(new FileOutputStream(this.outputFile), new Manifest());
    -		final Iterator<Class<?>> it = this.classSet.iterator();
    -		while (it.hasNext()) {
    +		try ( JarOutputStream jos = new JarOutputStream(new FileOutputStream(this.outputFile), new Manifest())) {
    +			final Iterator<Class<?>> it = this.classSet.iterator();
    +			while (it.hasNext()) {
     
    -			final Class<?> clazz = it.next();
    -			final String entry = clazz.getName().replace('.', '/') + CLASS_EXTENSION;
    +				final Class<?> clazz = it.next();
    +				final String entry = clazz.getName().replace('.', '/') + CLASS_EXTENSION;
     
    -			jos.putNextEntry(new JarEntry(entry));
    +				jos.putNextEntry(new JarEntry(entry));
     
    -			String name = clazz.getName();
    -			int n = name.lastIndexOf('.');
    -			String className = null;
    -			if (n > -1) {
    -				className = name.substring(n + 1, name.length());
    -			}
    -			//Using the part after last dot instead of class.getSimpleName() could resolve the problem of inner class.
    -			final InputStream classInputStream = clazz.getResourceAsStream(className + CLASS_EXTENSION);
    +				String name = clazz.getName();
    +				int n = name.lastIndexOf('.');
    +				String className = null;
    +				if (n > -1) {
    +					className = name.substring(n + 1, name.length());
    +				}
    +				//Using the part after last dot instead of class.getSimpleName() could resolve the problem of inner class.
    +				final InputStream classInputStream = clazz.getResourceAsStream(className + CLASS_EXTENSION);
     
    -			int num = classInputStream.read(buf);
    -			while (num != -1) {
    -				jos.write(buf, 0, num);
    -				num = classInputStream.read(buf);
    -			}
    +				int num = classInputStream.read(buf);
    +				while (num != -1) {
    +					jos.write(buf, 0, num);
    +					num = classInputStream.read(buf);
    +				}
     
    -			classInputStream.close();
    -			jos.closeEntry();
    +				classInputStream.close();
    +				jos.closeEntry();
    +			}
     		}
    -		jos.close();
    --- End diff --
    
    close() is now never called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---