You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/03 06:46:24 UTC
[GitHub] [pulsar] hangc0276 commented on a change in pull request #12378: [pulsar-broker] Provide option to split bundle based on load
hangc0276 commented on a change in pull request #12378:
URL: https://github.com/apache/pulsar/pull/12378#discussion_r741651597
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -1167,8 +1166,22 @@ protected void internalSplitNamespaceBundle(AsyncResponse asyncResponse, String
});
}
+ private String getBundleRange(String bundleName) {
+ if (BundleType.LARGEST.toString().equals(bundleName)) {
+ return findLargestBundleWithTopics(namespaceName).getBundleRange();
+ } else if (BundleType.HOT.toString().equals(bundleName)) {
+ return findHotBundle(namespaceName).getBundleRange();
Review comment:
Should we check `findHotBundle(namespaceName)` is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org