[GitHub] [cloudstack] ravening commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #4359:
URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503750115



##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
                     }
                     // update password for this host
                     final DetailVO nv = _detailsDao.findDetail(h.getId(), ApiConstants.USERNAME);
-                    if (nv.getValue().equals(command.getUsername())) {
+                    if (nv == null) {
+                        final DetailVO nvu = new DetailVO(h.getId(), ApiConstants.USERNAME, command.getUsername());

Review comment:
       @sureshanaparti username and password are mandatory parameters.. They cant be null
   
   ```
   (local) 🐱 > update hostpassword hostid=50c8-b73a-4eaf-bbab-7a70
   💩 Missing required parameters:  password, username
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org