You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/03 08:17:14 UTC

[GitHub] [spark] yaooqinn opened a new pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

yaooqinn opened a new pull request #34794:
URL: https://github.com/apache/spark/pull/34794


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   APIs like sc.newHadoopFile accepts a string representation of comma separate paths, which could be very very long, and we set it directly as the RDD name. This could be an unfriendly name on the UI and cost tons of driver memory for the whole RDD scope.
   
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   make the RDD name on UI more friendly
   make it cost less driver memory
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   yes, for a single RDD like this, user will see a much short one
   
   ![image](https://user-images.githubusercontent.com/8326978/144568404-bbfa9074-52b7-4a2b-a71a-a73719233f4c.png)
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   passing GA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985367723


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985315966


   **[Test build #145892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145892/testReport)** for PR 34794 at commit [`de2be74`](https://github.com/apache/spark/commit/de2be7478a3fb2e3e0a2c762acfd87f64f8ec7dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r761817215



##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -152,7 +153,7 @@ abstract class RDD[T: ClassTag](
 
   /** Assign a name to this RDD */
   def setName(_name: String): this.type = {
-    name = _name
+    name = StringUtils.abbreviate(_name, conf.get(MAX_RDD_NAME_LENGTH))

Review comment:
       _name seems only to be used by `RDD.toString` and the `toDebugString` does not depend on it
   
   https://github.com/apache/spark/blob/35848385ae6518b4b72c2f5c1e9ca5a83a190723/core/src/main/scala/org/apache/spark/rdd/RDD.scala#L2008-L2009
   
   Guess it's safe to change? otherwise, we have to try to keep the class name and call site if we abbreviate in UI




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985440479


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50370/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r762676403



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2267,4 +2267,13 @@ package object config {
       .version("3.3.0")
       .intConf
       .createWithDefault(5)
+
+  private[spark]val MAX_RDD_NAME_LENGTH = ConfigBuilder("spark.rdd.nameMaxLength")
+    .internal()
+    .doc("Maximum number of characters for RDD name. For example, some of the HadoopRDD API will" +
+      "use the path parameter as RDD name which could be extremely long")
+    .version("3.3.0")
+    .intConf
+    .checkValue(_ > 3, "This value must be bigger than 3.")
+    .createWithDefault(256)

Review comment:
       yes, I had intended to change the spark auto-generated ones, such as
   
   https://github.com/apache/spark/blob/abecdfe831805fb53fa949558ea7a5ca9042e465/core/src/main/scala/org/apache/spark/SparkContext.scala#L992
   
   https://github.com/apache/spark/blob/abecdfe831805fb53fa949558ea7a5ca9042e465/core/src/main/scala/org/apache/spark/SparkContext.scala#L1044
   
   https://github.com/apache/spark/blob/abecdfe831805fb53fa949558ea7a5ca9042e465/core/src/main/scala/org/apache/spark/SparkContext.scala#L1269
   
    How about that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r762680264



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2267,4 +2267,13 @@ package object config {
       .version("3.3.0")
       .intConf
       .createWithDefault(5)
+
+  private[spark]val MAX_RDD_NAME_LENGTH = ConfigBuilder("spark.rdd.nameMaxLength")
+    .internal()
+    .doc("Maximum number of characters for RDD name. For example, some of the HadoopRDD API will" +
+      "use the path parameter as RDD name which could be extremely long")
+    .version("3.3.0")
+    .intConf
+    .checkValue(_ > 3, "This value must be bigger than 3.")
+    .createWithDefault(256)

Review comment:
       It might be good to make them shorter and more meaningful, but is this not ultimately a display issue?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985366817


   **[Test build #145895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145895/testReport)** for PR 34794 at commit [`9188990`](https://github.com/apache/spark/commit/91889904555522c819992ea3d947e71f0b9eb29a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r762676403



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2267,4 +2267,13 @@ package object config {
       .version("3.3.0")
       .intConf
       .createWithDefault(5)
+
+  private[spark]val MAX_RDD_NAME_LENGTH = ConfigBuilder("spark.rdd.nameMaxLength")
+    .internal()
+    .doc("Maximum number of characters for RDD name. For example, some of the HadoopRDD API will" +
+      "use the path parameter as RDD name which could be extremely long")
+    .version("3.3.0")
+    .intConf
+    .checkValue(_ > 3, "This value must be bigger than 3.")
+    .createWithDefault(256)

Review comment:
       yes, I had intended to change the spark auto-generated ones, which might be too much longer than user's expectation,  such as
   
   https://github.com/apache/spark/blob/abecdfe831805fb53fa949558ea7a5ca9042e465/core/src/main/scala/org/apache/spark/SparkContext.scala#L992
   
   https://github.com/apache/spark/blob/abecdfe831805fb53fa949558ea7a5ca9042e465/core/src/main/scala/org/apache/spark/SparkContext.scala#L1044
   
   https://github.com/apache/spark/blob/abecdfe831805fb53fa949558ea7a5ca9042e465/core/src/main/scala/org/apache/spark/SparkContext.scala#L1269
   
    How about that? also cc @srowen 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r762684556



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2267,4 +2267,13 @@ package object config {
       .version("3.3.0")
       .intConf
       .createWithDefault(5)
+
+  private[spark]val MAX_RDD_NAME_LENGTH = ConfigBuilder("spark.rdd.nameMaxLength")
+    .internal()
+    .doc("Maximum number of characters for RDD name. For example, some of the HadoopRDD API will" +
+      "use the path parameter as RDD name which could be extremely long")
+    .version("3.3.0")
+    .intConf
+    .checkValue(_ > 3, "This value must be bigger than 3.")
+    .createWithDefault(256)

Review comment:
       > but is this not ultimately a display issue?
   
   Yes, let me try to fix it at UI side




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985315966


   **[Test build #145892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145892/testReport)** for PR 34794 at commit [`de2be74`](https://github.com/apache/spark/commit/de2be7478a3fb2e3e0a2c762acfd87f64f8ec7dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985363363


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985446091


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50370/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985482651


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145895/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985367723


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #34794:
URL: https://github.com/apache/spark/pull/34794


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985367685


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50367/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985482651


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145895/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985446091


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50370/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985480133


   **[Test build #145895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145895/testReport)** for PR 34794 at commit [`9188990`](https://github.com/apache/spark/commit/91889904555522c819992ea3d947e71f0b9eb29a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985317123


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145892/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r761802277



##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -152,7 +153,7 @@ abstract class RDD[T: ClassTag](
 
   /** Assign a name to this RDD */
   def setName(_name: String): this.type = {
-    name = _name
+    name = StringUtils.abbreviate(_name, conf.get(MAX_RDD_NAME_LENGTH))

Review comment:
       Hm .. shouldn't we just abbreviate in UI instead of abbreviate the name itself?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #34794:
URL: https://github.com/apache/spark/pull/34794


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] commented on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-1069766549


   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985317107


   **[Test build #145892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145892/testReport)** for PR 34794 at commit [`de2be74`](https://github.com/apache/spark/commit/de2be7478a3fb2e3e0a2c762acfd87f64f8ec7dd).
    * This patch **fails Scala style tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985317123


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145892/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][Core] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985366817


   **[Test build #145895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145895/testReport)** for PR 34794 at commit [`9188990`](https://github.com/apache/spark/commit/91889904555522c819992ea3d947e71f0b9eb29a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34794:
URL: https://github.com/apache/spark/pull/34794#issuecomment-985410752


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50370/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r762472083



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2267,4 +2267,13 @@ package object config {
       .version("3.3.0")
       .intConf
       .createWithDefault(5)
+
+  private[spark]val MAX_RDD_NAME_LENGTH = ConfigBuilder("spark.rdd.nameMaxLength")
+    .internal()
+    .doc("Maximum number of characters for RDD name. For example, some of the HadoopRDD API will" +
+      "use the path parameter as RDD name which could be extremely long")
+    .version("3.3.0")
+    .intConf
+    .checkValue(_ > 3, "This value must be bigger than 3.")
+    .createWithDefault(256)

Review comment:
       @yaooqinn .
   - This looks like a breaking change for the downstream expecting the same names they set.
   - If we need this configuration, the default value should be `Int.MaxValue` at least too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org