[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4497: Add a thread in ControllerLeadershipManager to periodically fetch controller leadership info

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4497: Add a thread in ControllerLeadershipManager to periodically fetch controller leadership info
URL: https://github.com/apache/incubator-pinot/pull/4497#discussion_r310856570
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java
 ##########
 @@ -60,17 +101,35 @@ public synchronized void subscribe(String name, LeadershipChangeSubscriber subsc
     }
   }
 
-  public boolean isLeader() {
+  public synchronized boolean isLeader() {
 
 Review comment:
   Good catch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org