You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2025/08/02 11:41:59 UTC
(superset) branch master updated: fix(echart): initial chart animation (#34516)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 1a7a381bd5 fix(echart): initial chart animation (#34516)
1a7a381bd5 is described below
commit 1a7a381bd574665d4694be4a7554962f8edd98ad
Author: JUST.in DO IT <ju...@airbnb.com>
AuthorDate: Sat Aug 2 04:41:53 2025 -0700
fix(echart): initial chart animation (#34516)
---
.../plugins/plugin-chart-echarts/src/components/Echart.tsx | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
index 6eb2b70d74..88d2b5a9dc 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
@@ -174,6 +174,8 @@ function Echart(
if (!chartRef.current) {
chartRef.current = init(divRef.current, null, { locale });
}
+ // did mount
+ handleSizeChange({ width, height });
setDidMount(true);
});
}, [locale]);
@@ -235,9 +237,6 @@ function Echart(
echartOptions,
);
chartRef.current?.setOption(themedEchartOptions, true);
-
- // did mount
- handleSizeChange({ width, height });
}
}, [didMount, echartOptions, eventHandlers, zrEventHandlers, theme]);