You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 11:58:15 UTC
[GitHub] [spark] ulysses-you opened a new pull request, #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
ulysses-you opened a new pull request, #36488:
URL: https://github.com/apache/spark/pull/36488
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add a new leaf like node `ResolvedLeafObject` and apply to the list:
- ResolvedDBObjectName
- ResolvedNamespace
- ResolvedTable
- ResolvedView
- ResolvedNonPersistentFunc
- ResolvedPersistentFunc
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We enable v2 command at 3.3.0 branch by default `spark.sql.legacy.useV1Command`. However this is a behavior change between v1 and c2 command.
- v1 command:
We resolve logical plan to command at analyzer phase by `ResolveSessionCatalog`
- v2 commnd:
We resolve logical plan to v2 command at physical phase by `DataSourceV2Strategy`
Foe cost explain mode, we will call `LogicalPlanStats.stats` using optimized plan so there is a gap between v1 and v2 command.
Unfortunately, the logical plan of v2 command contains the `LeafNode` which does not override the `computeStats`. As a result, there is a error running such sql:
```sql
set spark.sql.ui.explainMode=cost;
show tables;
```
```
java.lang.UnsupportedOperationException:
at org.apache.spark.sql.catalyst.plans.logical.LeafNode.computeStats(LogicalPlan.scala:171)
at org.apache.spark.sql.catalyst.plans.logical.LeafNode.computeStats$(LogicalPlan.scala:171)
at org.apache.spark.sql.catalyst.analysis.ResolvedNamespace.computeStats(v2ResolutionPlans.scala:155)
at org.apache.spark.sql.catalyst.plans.logical.statsEstimation.SizeInBytesOnlyStatsPlanVisitor$.default(SizeInBytesOnlyStatsPlanVisitor.scala:55)
at org.apache.spark.sql.catalyst.plans.logical.statsEstimation.SizeInBytesOnlyStatsPlanVisitor$.default(SizeInBytesOnlyStatsPlanVisitor.scala:27)
at org.apache.spark.sql.catalyst.plans.logical.LogicalPlanVisitor.visit(LogicalPlanVisitor.scala:49)
at org.apache.spark.sql.catalyst.plans.logical.LogicalPlanVisitor.visit$(LogicalPlanVisitor.scala:25)
at org.apache.spark.sql.catalyst.plans.logical.statsEstimation.SizeInBytesOnlyStatsPlanVisitor$.visit(SizeInBytesOnlyStatsPlanVisitor.scala:27)
at org.apache.spark.sql.catalyst.plans.logical.statsEstimation.LogicalPlanStats.$anonfun$stats$1(LogicalPlanStats.scala:37)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.spark.sql.catalyst.plans.logical.statsEstimation.LogicalPlanStats.stats(LogicalPlanStats.scala:33)
at org.apache.spark.sql.catalyst.plans.logical.statsEstimation.LogicalPlanStats.stats$(LogicalPlanStats.scala:33)
at org.apache.spark.sql.catalyst.plans.logical.LogicalPlan.stats(LogicalPlan.scala:30)
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, bug fix
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #36488:
URL: https://github.com/apache/spark/pull/36488#issuecomment-1123239435
thanks, merging to master/3.3!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869234844
##########
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala:
##########
@@ -528,6 +528,23 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
"== Analyzed Logical Plan ==\nCreateViewCommand")
}
}
+
+ test("SPARK-39112: UnsupportedOperationException if spark.sql.ui.explainMode is set to cost") {
+ withSQLConf(SQLConf.UI_EXPLAIN_MODE.key -> "cost") {
Review Comment:
can we simply test with `EXPLAIN COST ...` command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869800379
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String], isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
+ */
+trait LeafNodeWithoutStats extends LogicalPlan with LeafLike[LogicalPlan] {
Review Comment:
changed to `trait LeafNodeWithoutStats extend LeafNode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #36488:
URL: https://github.com/apache/spark/pull/36488#issuecomment-1121036491
cc @cloud-fan @HyukjinKwon @wangyum @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
URL: https://github.com/apache/spark/pull/36488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869781994
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String], isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
Review Comment:
```suggestion
* A resolved leaf node whose statistics has no meaning.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869782275
##########
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala:
##########
@@ -528,6 +528,21 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
"== Analyzed Logical Plan ==\nCreateViewCommand")
}
}
+
+ test("SPARK-39112: UnsupportedOperationException if spark.sql.ui.explainMode is set to cost") {
Review Comment:
the test name needs update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869781957
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String], isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
+ */
+trait LeafNodeWithoutStats extends LogicalPlan with LeafLike[LogicalPlan] {
Review Comment:
Can we make it an abstract class and extends `LeafNode`? I'm a bit worried about changing the class hierarchy unnecessarily in this PR.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String], isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
Review Comment:
```suggestion
* A resolved leaf like node that its statistics has no meaning.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #36488: [SPARK-39112][SQL] UnsupportedOperationException if spark.sql.ui.explainMode is set to cost
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #36488:
URL: https://github.com/apache/spark/pull/36488#discussion_r869233995
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -140,11 +141,19 @@ case class UnresolvedDBObjectName(nameParts: Seq[String], isNamespace: Boolean)
override def output: Seq[Attribute] = Nil
}
+/**
+ * A resolved leaf like node that its statistics is no meaning.
+ */
+trait ResolvedLeafObject extends LogicalPlan with LeafLike[LogicalPlan] {
Review Comment:
nit: `LeafNodeWithoutStats` seems better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org