You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by joferna <gi...@git.apache.org> on 2017/10/02 02:23:27 UTC
[GitHub] tomcat pull request #73: Bug 57767 - Websocket client proprietary configurat...
GitHub user joferna opened a pull request:
https://github.com/apache/tomcat/pull/73
Bug 57767 - Websocket client proprietary configuration
The original patch for redirection support (https://bz.apache.org/bugzilla/show_bug.cgi?id=57767) is not compliant with the websocket spec since the redirectSet variable is not thread-safe. This pull request aims to fix the concurrency issue by creating a new class "WsWebSocketClient" with its own set of variables. It also includes the proposed changes for authentication support.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joferna/tomcat trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit 7c3d9a4d9e6031d420523bb336ca73f4bf6d8c42
Author: Jorge Fernandez <jf...@fiu.edu>
Date: 2017-09-29T04:21:05Z
basic/digest patch
commit 19d03e6df4196c4f026ec33fb6121774d587ab9e
Author: Jorge Fernandez <jf...@fiu.edu>
Date: 2017-09-29T05:15:14Z
added new client class
commit 2f372a7ad863408fbb43bac21d3239df3f9c5d49
Author: Jorge Fernandez <jf...@fiu.edu>
Date: 2017-09-30T22:36:24Z
added correct logger
commit 080464ea84f1adc3fd25df4c7d1e4c2549c75c43
Author: Jorge Fernandez <jf...@fiu.edu>
Date: 2017-09-30T23:24:00Z
Preserve previous connecttoserver formatting
commit 1a74c3a36de7ac6064a078acedcb128b98c7024c
Author: Jorge Fernandez <jf...@fiu.edu>
Date: 2017-10-02T01:38:01Z
Update localString
commit ca2c7a5d883fdc1b4e5d98096923c099c7d934dc
Author: joferna <24...@users.noreply.github.com>
Date: 2017-10-02T02:07:25Z
Merge pull request #1 from joferna/ConcurrentWsAuth
Bug 57767 - Websocket client proprietary configuration
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #73: Bug 57767 - Websocket client proprietary configuration
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/73
Chris's original concern with the BZ 57767 patch (lack of Javadoc) still needs to be addressed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #73: Bug 57767 - Websocket client proprietary configuration
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/73
No objections to back-porting here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #73: Bug 57767 - Websocket client proprietary configuration
Posted by rmaucher <gi...@git.apache.org>.
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/73
Well, it looks ok to me overall, so I'll add a bit of javadoc and merge it. Any issue with backporting it ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #73: Bug 57767 - Websocket client proprietary configurat...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/73
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org