[GitHub] [incubator-doris] morningman commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.
URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r407059051
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
 ##########
 @@ -1148,8 +1149,7 @@ private void updateDBRunningTxnNum(TransactionStatus preStatus, TransactionState
                 && (curTxnState.getTransactionStatus() == TransactionStatus.PREPARE
                 || curTxnState.getTransactionStatus() == TransactionStatus.COMMITTED)) {
             ++txnNum;
-        } else if (preStatus != null
-                && (preStatus == TransactionStatus.PREPARE
+        } else if ((preStatus == TransactionStatus.PREPARE
 
 Review comment:
   Why removing the `preStatus != null` check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org