You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/02/17 00:39:43 UTC
[GitHub] [druid] jon-wei opened a new pull request #12264: Re-enable segment metadata cache when using external schema
jon-wei opened a new pull request #12264:
URL: https://github.com/apache/druid/pull/12264
This PR re-enables the segment metadata caching within `DruidSchema` when using an external schema provider, as the `sys.segments` table relies on this information for determining segment availability.
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zachjsh commented on a change in pull request #12264: Re-enable segment metadata cache when using external schema
Posted by GitBox <gi...@apache.org>.
zachjsh commented on a change in pull request #12264:
URL: https://github.com/apache/druid/pull/12264#discussion_r809411728
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -375,11 +373,7 @@ private void startCacheExec()
@LifecycleStart
public void start() throws InterruptedException
{
- if (druidSchemaManager == null || druidSchemaManager instanceof NoopDruidSchemaManager) {
- startCacheExec();
- } else {
- initialized.countDown();
- }
+ startCacheExec();
Review comment:
What was the reasoning behind disabling the cache when schemaManager is enabled in first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #12264: Re-enable segment metadata cache when using external schema
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #12264:
URL: https://github.com/apache/druid/pull/12264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org