You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2022/08/31 14:40:45 UTC
[plc4x] 01/03: fix(plc4j/s7): Fixed the PLC4X272 test and made it run automatically.
This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit 865d5effcda2ce3f9f6e505213e2150dfb6ad6af
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Wed Aug 31 16:38:47 2022 +0200
fix(plc4j/s7): Fixed the PLC4X272 test and made it run automatically.
---
.../readwrite/issues/{PLC4X272.java => PLC4X272Test.java} | 4 ++--
plc4j/drivers/s7/src/test/resources/tests/PLC4X-272.xml | 14 +++++++-------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/readwrite/issues/PLC4X272.java b/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/readwrite/issues/PLC4X272Test.java
similarity index 91%
rename from plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/readwrite/issues/PLC4X272.java
rename to plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/readwrite/issues/PLC4X272Test.java
index f6773e59e..d463ba9ef 100644
--- a/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/readwrite/issues/PLC4X272.java
+++ b/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/readwrite/issues/PLC4X272Test.java
@@ -20,9 +20,9 @@ package org.apache.plc4x.java.s7.readwrite.issues;
import org.apache.plc4x.test.driver.DriverTestsuiteRunner;
-public class PLC4X272 extends DriverTestsuiteRunner {
+public class PLC4X272Test extends DriverTestsuiteRunner {
- public PLC4X272() {
+ public PLC4X272Test() {
super("/tests/PLC4X-272.xml");
}
diff --git a/plc4j/drivers/s7/src/test/resources/tests/PLC4X-272.xml b/plc4j/drivers/s7/src/test/resources/tests/PLC4X-272.xml
index b9829f1c4..662901906 100644
--- a/plc4j/drivers/s7/src/test/resources/tests/PLC4X-272.xml
+++ b/plc4j/drivers/s7/src/test/resources/tests/PLC4X-272.xml
@@ -60,13 +60,6 @@
</protocolClass>
</COTPPacketConnectionRequest>
<parameters isList="true">
- <COTPParameter>
- <parameterType dataType="uint" bitLength="8">194</parameterType>
- <parameterLength dataType="uint" bitLength="8">2</parameterLength>
- <COTPParameterCalledTsap>
- <tsapId dataType="uint" bitLength="16">256</tsapId>
- </COTPParameterCalledTsap>
- </COTPParameter>
<COTPParameter>
<parameterType dataType="uint" bitLength="8">193</parameterType>
<parameterLength dataType="uint" bitLength="8">2</parameterLength>
@@ -74,6 +67,13 @@
<tsapId dataType="uint" bitLength="16">785</tsapId>
</COTPParameterCallingTsap>
</COTPParameter>
+ <COTPParameter>
+ <parameterType dataType="uint" bitLength="8">194</parameterType>
+ <parameterLength dataType="uint" bitLength="8">2</parameterLength>
+ <COTPParameterCalledTsap>
+ <tsapId dataType="uint" bitLength="16">256</tsapId>
+ </COTPParameterCalledTsap>
+ </COTPParameter>
<COTPParameter>
<parameterType dataType="uint" bitLength="8">192</parameterType>
<parameterLength dataType="uint" bitLength="8">1</parameterLength>