You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/04/21 14:33:35 UTC
[GitHub] [superset] rusackas opened a new pull request, #23772: chore(e2e): skip the worst offender of flaky tests.
rusackas opened a new pull request, #23772:
URL: https://github.com/apache/superset/pull/23772
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<img width="1525" alt="image" src="https://user-images.githubusercontent.com/812905/233662715-4942b643-b48d-4fcd-bca7-2a2d1e3c599a.png">
Kills this 👆
Adds a TODO for some generous soul who comes along to clean house one fateful day.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Run E2E
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23772: chore(e2e): skip the worst offender of flaky tests.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23772:
URL: https://github.com/apache/superset/pull/23772#issuecomment-1517942176
## [Codecov](https://codecov.io/gh/apache/superset/pull/23772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23772](https://codecov.io/gh/apache/superset/pull/23772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b7d96c) into [master](https://codecov.io/gh/apache/superset/commit/764c3c95cf3be732b50a17282d510b03beddca0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (764c3c9) will **decrease** coverage by `11.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23772 +/- ##
===========================================
- Coverage 67.87% 56.65% -11.23%
===========================================
Files 1924 1924
Lines 74381 74381
Branches 8106 8106
===========================================
- Hits 50486 42140 -8346
- Misses 21818 30164 +8346
Partials 2077 2077
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.92% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.84% <ø> (ø)` | |
| python | `59.39% <ø> (-23.26%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.72% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 302 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23772/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23772: chore(e2e): skip the worst offender of flaky tests.
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23772:
URL: https://github.com/apache/superset/pull/23772#discussion_r1173951641
##########
superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts:
##########
@@ -734,7 +734,8 @@ describe('Dashboard edit', () => {
cy.getBySel('dashboard-charts-filter-search-input').clear();
});
- it('should disable the Save button when undoing', () => {
+ // TODO fix this test! This was the #1 flaky test as of 4/21/23 according to cypress dashboard.
+ xit('should disable the Save button when undoing', () => {
Review Comment:
not sure about worst offender; This test was restarted 11 times before I finally caved in and `xit`ed it in #23751 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23772: chore(e2e): skip the worst offender of flaky tests.
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23772:
URL: https://github.com/apache/superset/pull/23772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org