You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2011/12/16 01:03:32 UTC
[jira] [Created] (HADOOP-7928) HA: Client failover policy is
incorrectly trying to fail over all IOExceptions
HA: Client failover policy is incorrectly trying to fail over all IOExceptions
------------------------------------------------------------------------------
Key: HADOOP-7928
URL: https://issues.apache.org/jira/browse/HADOOP-7928
Project: Hadoop Common
Issue Type: Sub-task
Components: ha, ipc
Affects Versions: HA Branch (HDFS-1623)
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
In the {{FailoverOnNetworkExceptionRetry}} implementation, we're returning FAILOVER_AND_RETRY for any IOException, so long as the call is idempotent. So, for example, {{getFileInfo}} on a file you don't have access to throws AccessControlException which incorrectly triggers a failover. We should not failover on RemoteExceptions unless they are StandbyException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7928) HA: Client failover policy is
incorrectly trying to fail over all IOExceptions
Posted by "Aaron T. Myers (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers resolved HADOOP-7928.
------------------------------------
Resolution: Fixed
Fix Version/s: HA Branch (HDFS-1623)
Hadoop Flags: Reviewed
Thanks a lot for the quick review, Todd. I've just committed this to the HA branch.
> HA: Client failover policy is incorrectly trying to fail over all IOExceptions
> ------------------------------------------------------------------------------
>
> Key: HADOOP-7928
> URL: https://issues.apache.org/jira/browse/HADOOP-7928
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Blocker
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: HADOOP-7928-HDFS-1623.patch
>
>
> In the {{FailoverOnNetworkExceptionRetry}} implementation, we're returning FAILOVER_AND_RETRY for any IOException, so long as the call is idempotent. So, for example, {{getFileInfo}} on a file you don't have access to throws AccessControlException which incorrectly triggers a failover. We should not failover on RemoteExceptions unless they are StandbyException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7928) HA: Client failover policy is
incorrectly trying to fail over all IOExceptions
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171060#comment-13171060 ]
Hudson commented on HADOOP-7928:
--------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #18 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/18/])
HADOOP-7928. HA: Client failover policy is incorrectly trying to fail over all IOExceptions. Contributed by Aaron T. Myers.
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215019
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestFailoverProxy.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/UnreliableImplementation.java
> HA: Client failover policy is incorrectly trying to fail over all IOExceptions
> ------------------------------------------------------------------------------
>
> Key: HADOOP-7928
> URL: https://issues.apache.org/jira/browse/HADOOP-7928
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Blocker
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: HADOOP-7928-HDFS-1623.patch
>
>
> In the {{FailoverOnNetworkExceptionRetry}} implementation, we're returning FAILOVER_AND_RETRY for any IOException, so long as the call is idempotent. So, for example, {{getFileInfo}} on a file you don't have access to throws AccessControlException which incorrectly triggers a failover. We should not failover on RemoteExceptions unless they are StandbyException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7928) HA: Client failover policy is
incorrectly trying to fail over all IOExceptions
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HADOOP-7928:
-----------------------------------
Attachment: HADOOP-7928-HDFS-1623.patch
Here's a patch which addresses the issue.
> HA: Client failover policy is incorrectly trying to fail over all IOExceptions
> ------------------------------------------------------------------------------
>
> Key: HADOOP-7928
> URL: https://issues.apache.org/jira/browse/HADOOP-7928
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Blocker
> Attachments: HADOOP-7928-HDFS-1623.patch
>
>
> In the {{FailoverOnNetworkExceptionRetry}} implementation, we're returning FAILOVER_AND_RETRY for any IOException, so long as the call is idempotent. So, for example, {{getFileInfo}} on a file you don't have access to throws AccessControlException which incorrectly triggers a failover. We should not failover on RemoteExceptions unless they are StandbyException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7928) HA: Client failover policy is
incorrectly trying to fail over all IOExceptions
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170678#comment-13170678 ]
Todd Lipcon commented on HADOOP-7928:
-------------------------------------
Looks good to me, thanks. +1
> HA: Client failover policy is incorrectly trying to fail over all IOExceptions
> ------------------------------------------------------------------------------
>
> Key: HADOOP-7928
> URL: https://issues.apache.org/jira/browse/HADOOP-7928
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, ipc
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Blocker
> Attachments: HADOOP-7928-HDFS-1623.patch
>
>
> In the {{FailoverOnNetworkExceptionRetry}} implementation, we're returning FAILOVER_AND_RETRY for any IOException, so long as the call is idempotent. So, for example, {{getFileInfo}} on a file you don't have access to throws AccessControlException which incorrectly triggers a failover. We should not failover on RemoteExceptions unless they are StandbyException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira