You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by ok...@apache.org on 2016/02/10 20:35:30 UTC
[2/5] incubator-tinkerpop git commit: Trying to harden up a test that
randomly fails some environments. CTR
Trying to harden up a test that randomly fails some environments. CTR
Increased the timeout length and asserted the result for awaitTermination() on the ExecutorService - in that way, if there is a failure due to timeout we at least know that it occurred as a result of that and not general failure of the test itself.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/58b784bb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/58b784bb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/58b784bb
Branch: refs/heads/master
Commit: 58b784bb2f25448730aa3ae7bfb93b274b685f25
Parents: 688df01
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Wed Feb 10 11:58:28 2016 -0500
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Wed Feb 10 11:58:28 2016 -0500
----------------------------------------------------------------------
.../gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/58b784bb/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java
----------------------------------------------------------------------
diff --git a/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java b/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java
index 86d7e7a..cddea53 100644
--- a/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java
+++ b/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java
@@ -52,6 +52,7 @@ import java.util.stream.IntStream;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.greaterThan;
+import static org.hamcrest.core.Is.is;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
@@ -359,7 +360,7 @@ public class GremlinGroovyScriptEngineTest {
});
service.shutdown();
- service.awaitTermination(30000, TimeUnit.MILLISECONDS);
+ assertThat(service.awaitTermination(120000, TimeUnit.MILLISECONDS), is(true));
assertEquals(max, futures.size());
futures.forEach(t -> {