[GitHub] [hudi] yihua commented on a change in pull request #4021: [HUDI-2671] Fix kafka offset handling in Kafka Connect protocol

[GitBox <gi...@apache.org>]

yihua commented on a change in pull request #4021:
URL: https://github.com/apache/hudi/pull/4021#discussion_r756172606



##########
File path: hudi-kafka-connect/src/main/java/org/apache/hudi/connect/transaction/ConnectTransactionParticipant.java
##########
@@ -201,9 +201,9 @@ private void handleEndCommit(ControlMessage message) {
   }
 
   private void handleAckCommit(ControlMessage message) {
-    // Update lastKafkCommitedOffset locally.
-    if (ongoingTransactionInfo != null && committedKafkaOffset < ongoingTransactionInfo.getLastWrittenKafkaOffset()) {
-      committedKafkaOffset = ongoingTransactionInfo.getLastWrittenKafkaOffset();
+    // // Update committedKafkaOffset that tracks the last committed kafka offset locally.

Review comment:
       Nit: remove additional `//` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org