You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/12/09 10:45:12 UTC

[Impala-ASF-CR] IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16843


Change subject: IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2
......................................................................

IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Bump the toolchain to a newer version that has Centos 8 binaries that
were built on Centos 8.2.
Centos 8.2 contains an updated version of glibc, which fixes several bugs,
at least one of which had also impacted Impala Centos 8 builds through
the binary toolchain. Details are described in see IMPALA-9985.

The new toolchain binaries can now compile Impala for Centos 8 without
the problems seen earlier in IMPALA-9985. This also means that the
minimum Centos 8 version required for Impala is now Centos 8.2.2004.

Unrelated to these bugs, the same toolchain version is now the first one
to drop support for Debian 8. As Debian 8 support was discontinued on
2020-06-30 (see: https://www.debian.org/News/2020/20200709),
IMPALA-10378 removes Debian 8 support from the toolchain.

Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/16843/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16843 )

Change subject: IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7802/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 11:05:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16843 )

Change subject: IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2
......................................................................

IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Bump the toolchain to a newer version that has Centos 8 binaries that
were built on Centos 8.2.
Centos 8.2 contains an updated version of glibc, which fixes several bugs,
at least one of which had also impacted Impala Centos 8 builds through
the binary toolchain. Details are described in see IMPALA-9985.

The new toolchain binaries can now compile Impala for Centos 8 without
the problems seen earlier in IMPALA-9985. This also means that the
minimum Centos 8 version required for Impala is now Centos 8.2.2004.

Unrelated to these bugs, the same toolchain version is now the first one
to drop support for Debian 8. As Debian 8 support was discontinued on
2020-06-30 (see: https://www.debian.org/News/2020/20200709),
IMPALA-10378 removes Debian 8 support from the toolchain.

Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Reviewed-on: http://gerrit.cloudera.org:8080/16843
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16843 )

Change subject: IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 17:46:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16843 )

Change subject: IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 19:26:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16843 )

Change subject: IMPALA-9985/IMPALA-10378: Bump toolchain to include Centos 8.2
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6742/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I061506e44872fc980630fc006658fdc778a75dd1
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 12:10:04 +0000
Gerrit-HasComments: No