You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/08 04:36:44 UTC

Re: Review Request 65538: Added resource provider selectors in `disk_profile.proto`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------

(Updated Feb. 8, 2018, 4:36 a.m.)


Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Summary (updated)
-----------------

Added resource provider selectors in `disk_profile.proto`.


Bugs: MESOS-8510
    https://issues.apache.org/jira/browse/MESOS-8510


Repository: mesos


Description
-------

This patch adds two selectors to the `CSIManifest` protobuf so that the
URI disk profile adaptor can be customized to notify each resource
provider with a different set of profiles.


Diffs (updated)
-----

  src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2 


Diff: https://reviews.apache.org/r/65538/diff/6/

Changes: https://reviews.apache.org/r/65538/diff/5-6/


Testing
-------

Tests done later in chain.


Thanks,

Chun-Hung Hsiao


Re: Review Request 65538: Added resource provider selectors in `disk_profile.proto`.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197113
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 8, 2018, 4:36 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2018, 4:36 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8510
>     https://issues.apache.org/jira/browse/MESOS-8510
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2 
> 
> 
> Diff: https://reviews.apache.org/r/65538/diff/6/
> 
> 
> Testing
> -------
> 
> Tests done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>