You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/03/18 02:24:42 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new pull request, #1327: test: Remove testdb and compactdb dirs on exit
tisonkun opened a new pull request, #1327:
URL: https://github.com/apache/incubator-kvrocks/pull/1327
This closes #798.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #1327: test: Remove testdb and compactdb dirs on exit
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1327:
URL: https://github.com/apache/incubator-kvrocks/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1327: test: Remove testdb and compactdb dirs on exit
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1327:
URL: https://github.com/apache/incubator-kvrocks/pull/1327#discussion_r1140902178
##########
tests/cppunit/compact_test.cc:
##########
@@ -18,9 +18,9 @@
*
*/
+#include <filesystem>
Review Comment:
I don't know if we should do conditional include here. But since we require C++17, it should be fine as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1327: test: Remove testdb and compactdb dirs on exit
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1327:
URL: https://github.com/apache/incubator-kvrocks/pull/1327#discussion_r1140902112
##########
.gitignore:
##########
@@ -31,19 +31,18 @@
*.out
*.app
-*.o
Review Comment:
duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1327: test: Remove testdb and compactdb dirs on exit
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1327:
URL: https://github.com/apache/incubator-kvrocks/pull/1327#issuecomment-1474818001
Merging...
Thanks for your review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org