You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/07 17:05:11 UTC
[GitHub] [trafficcontrol] traeak commented on a change in pull request
#3367: astats increase file buffer size, fix compiler warnings
traeak commented on a change in pull request #3367: astats increase file buffer size, fix compiler warnings
URL: https://github.com/apache/trafficcontrol/pull/3367#discussion_r263478435
##########
File path: traffic_server/plugins/astats_over_http/astats_over_http.c
##########
@@ -298,19 +299,18 @@ static int getSpeed(char *inf, char *buffer, int bufferSize) {
static void appendSystemState(stats_state *my_state) {
char *interface = my_state->interfaceName;
- char buffer[2024];
- int bsize = 2024;
+ char buffer[16384];
Review comment:
Mitigation is fine. The plugin is so full of holes regarding unchecked conditions that it needs a general review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services