You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/12/22 20:56:15 UTC

Review Request 41658: Track the allocation candidates to bound the allocation queue.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41658/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Klaus Ma.


Bugs: MESOS-3157
    https://issues.apache.org/jira/browse/MESOS-3157


Repository: mesos


Description
-------

When there is churn in the cluster, frequent resource allocation
is required.  Maintain a set of allocation candidates so that we
don't end up running the same allocation multiple times.

This review is just for feedback. Not proposing it to be berged at this time.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 775182515dcb52bd873ecdf98c827320251a59c8 

Diff: https://reviews.apache.org/r/41658/diff/


Testing
-------

make check.


Thanks,

James Peach


Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41658/#review111675
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41658]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 7:56 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41658/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 7:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Klaus Ma.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When there is churn in the cluster, frequent resource allocation
> is required.  Maintain a set of allocation candidates so that we
> don't end up running the same allocation multiple times.
> 
> This review is just for feedback. Not proposing it to be berged at this time.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 775182515dcb52bd873ecdf98c827320251a59c8 
> 
> Diff: https://reviews.apache.org/r/41658/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>