You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Mahadev Konar <ma...@apache.org> on 2014/07/08 00:03:03 UTC
Review Request 23323: Ability to customize /tmp usage for ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23323/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-6408
https://issues.apache.org/jira/browse/AMBARI-6408
Repository: ambari
Description
-------
Ability to customize /tmp usage for ambari
Diffs
-----
ambari-agent/conf/unix/ambari-agent.ini ac37f16
ambari-agent/pom.xml ac27638
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 4f0baa9
ambari-agent/src/main/python/resource_management/libraries/script/script.py 69e7493
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py e7a0d47
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py f88d429
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py f08891e
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/service_check.py 15cee8a
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 0397817
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py fb96f93
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/service_check.py 2e2b6fa
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hcat_service_check.py fdfaa81
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 7453ed4
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py ae4da20
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/service_check.py 0dc534c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py c44acfa
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/service_check.py 0e96a77
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py a64f480
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/service_check.py e98d6cf
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 64e080e
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/service_check.py df8b13f
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py f55bc2d
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py de8b5ff
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py a7dd45b
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/service_check.py 1550c50
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 62e5764
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 7a4c667
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/service_check.py 8bd272f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_service_check.py cebcc42
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py dc3fbb6
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 59451aa
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/service_check.py 892ab11
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 03cd9ed
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 0e96a77
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py c401c4a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/service_check.py 5eaaf31
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py d097fa9
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service_check.py beae43a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 64e080e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/service_check.py 3c809d8
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/params.py c4f830b
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/service_check.py beae43a
Diff: https://reviews.apache.org/r/23323/diff/
Testing
-------
Manual and unit tests.
Thanks,
Mahadev Konar
Re: Review Request 23323: Ability to customize /tmp usage for ambari
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On July 8, 2014, 10:40 a.m., Andrew Onischuk wrote:
> > Hey, Mahadev LG, but the arcitecture that we used is that ambari-agent calls resource_management, and resouce_management is independent from the agent (meaning not importing it, this avoid different hard circular import logics in future). So it's better to pass a tmp directory to script as a parameter when calling it (that can be done in CustomServiceOrchestrator line 132). We done the same thing with debug level and any other info from the agent. This will make the modules as much independent as possible, so it's easier to maintain.
Also we should change RMFTestCase.py:90 to mock Script.get_tmp_dir (the method which returns tmp_dir received from agent)
with patch.object(Script, 'get_tmp_dir', return_value="/var/lib/ambari-agent/data/tmp"):
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23323/#review47439
-----------------------------------------------------------
On July 7, 2014, 10:02 p.m., Mahadev Konar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23323/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 10:02 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-6408
> https://issues.apache.org/jira/browse/AMBARI-6408
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ability to customize /tmp usage for ambari
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini ac37f16
> ambari-agent/pom.xml ac27638
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 4f0baa9
> ambari-agent/src/main/python/resource_management/libraries/script/script.py 69e7493
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py e7a0d47
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py f88d429
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py f08891e
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/service_check.py 15cee8a
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 0397817
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py fb96f93
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/service_check.py 2e2b6fa
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hcat_service_check.py fdfaa81
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 7453ed4
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py ae4da20
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/service_check.py 0dc534c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py c44acfa
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/service_check.py 0e96a77
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py a64f480
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/service_check.py e98d6cf
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 64e080e
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/service_check.py df8b13f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py f55bc2d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py de8b5ff
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py a7dd45b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/service_check.py 1550c50
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 62e5764
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 7a4c667
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/service_check.py 8bd272f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_service_check.py cebcc42
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py dc3fbb6
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 59451aa
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/service_check.py 892ab11
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 03cd9ed
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 0e96a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py c401c4a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/service_check.py 5eaaf31
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py d097fa9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service_check.py beae43a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 64e080e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/service_check.py 3c809d8
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/params.py c4f830b
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/service_check.py beae43a
>
> Diff: https://reviews.apache.org/r/23323/diff/
>
>
> Testing
> -------
>
> Manual and unit tests.
>
>
> Thanks,
>
> Mahadev Konar
>
>
Re: Review Request 23323: Ability to customize /tmp usage for ambari
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23323/#review47439
-----------------------------------------------------------
Hey, Mahadev LG, but the arcitecture that we used is that ambari-agent calls resource_management, and resouce_management is independent from the agent (meaning not importing it, this avoid different hard circular import logics in future). So it's better to pass a tmp directory to script as a parameter when calling it (that can be done in CustomServiceOrchestrator line 132). We done the same thing with debug level and any other info from the agent. This will make the modules as much independent as possible, so it's easier to maintain.
- Andrew Onischuk
On July 7, 2014, 10:02 p.m., Mahadev Konar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23323/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 10:02 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-6408
> https://issues.apache.org/jira/browse/AMBARI-6408
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ability to customize /tmp usage for ambari
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini ac37f16
> ambari-agent/pom.xml ac27638
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 4f0baa9
> ambari-agent/src/main/python/resource_management/libraries/script/script.py 69e7493
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py e7a0d47
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py f88d429
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py f08891e
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/service_check.py 15cee8a
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 0397817
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py fb96f93
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/service_check.py 2e2b6fa
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hcat_service_check.py fdfaa81
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 7453ed4
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py ae4da20
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/service_check.py 0dc534c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/params.py c44acfa
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/service_check.py 0e96a77
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py a64f480
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/service_check.py e98d6cf
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py 64e080e
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/service_check.py df8b13f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py f55bc2d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py de8b5ff
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py a7dd45b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/service_check.py 1550c50
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 62e5764
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 7a4c667
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/service_check.py 8bd272f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_service_check.py cebcc42
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py dc3fbb6
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 59451aa
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/service_check.py 892ab11
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 03cd9ed
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 0e96a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py c401c4a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/service_check.py 5eaaf31
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py d097fa9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service_check.py beae43a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 64e080e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/service_check.py 3c809d8
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/params.py c4f830b
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/service_check.py beae43a
>
> Diff: https://reviews.apache.org/r/23323/diff/
>
>
> Testing
> -------
>
> Manual and unit tests.
>
>
> Thanks,
>
> Mahadev Konar
>
>