You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Anirudh Subramanian <an...@apache.org> on 2018/05/15 19:16:55 UTC

[VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Hi all,

This is a call for releasing Apache MXNet (incubating) 1.2.0, release
candidate RC3.
As suggested by Justin and Henri, we have removed the two category b
license files: DevGuide.md from the release source tarball.

Apache MXNet (incubating) community has voted and approved the release.

Vote thread:
https://lists.apache.org/thread.html/fee7800da4b701cb62d6dd7c1b43efd44c94a3a386f3adb48f343d6e@%3Cdev.mxnet.apache.org%3E

Results thread:
https://lists.apache.org/thread.html/0a43205e47a02a528873e16fe0e5789dfcfebc8a8539f17bbcde2062@%3Cdev.mxnet.apache.org%3E

The source tarball, including signatures, digests etc. can be found at:
https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc3/

The release tag can be found here:
https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3

<https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3>
The release hash is 297c64fd2ee404612aa3ecc880b940fb2538039c and can be
found here:
https://github.com/apache/incubator-mxnet/commit/297c64fd2ee404612aa3ecc880b940fb2538039c

<https://github.com/apache/incubator-mxnet/commit/297c64fd2ee404612aa3ecc880b940fb2538039c>
Release artifacts are signed with the following key:
0D04 3D0F 92CA 7333 22A8  D131 9067 CC8E AF55 CD6D

KEYS file available:

https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS

For information on the contents of the release see:

https://cwiki.apache.org/confluence/display/MXNET/
Apache+MXNet+%28incubating%29+1.2.0+Release+Notes

The vote will end at 1:00 PM on Friday, May 18th, PDT.

[ ] +1 Release this package as 1.2.0
[ ] +0 no opinion
[ ] -1 Do not release this package because ...


Anirudh

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> I had a look at the files and found that the key required to verify the signature is not contained in the KEYS file in the tar ball. 

AFAIK having the KEY file in the tar ball is not really helpful at all as it could be modified and republished. The KEY file needs to be stored alongside the release [1], hashes and KEYS are hashes not propagated on the mirror system. [2]

Thanks,
Justin

1. https://www.apache.org/dev/release-signing.html#keys-policy
2. http://www.apache.org/dev/release-publishing.html#distribution_dist
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Posted by Sebastian <ss...@apache.org>.
Hi,

I had a look at the files and found that the key required to verify the 
signature is not contained in the KEYS file in the tar ball. It has to 
be downloaded from an external keyserver.

Not sure about the consequences of that, is it a minor thing or should a 
new RC be cut?

Best,
Sebastian

On 19.05.2018 00:14, Sergio Fernández wrote:
> +1 (binding)
> 
> So far I've checked:
> * signatures and digests
> * source releases file layouts
> * matched git tags and commit ids
> * incubator suffix and disclaimer
> * LICENSE & NOTICE files look good despite the many third-party code (CC-BY
> files from RC2 are gone)
> * no binary files in the source release
> * clean build
> 
> 
> 
> On Tue, May 15, 2018 at 12:16 PM, Anirudh Subramanian <
> anirudh2290@apache.org> wrote:
> 
>> Hi all,
>>
>> This is a call for releasing Apache MXNet (incubating) 1.2.0, release
>> candidate RC3.
>> As suggested by Justin and Henri, we have removed the two category b
>> license files: DevGuide.md from the release source tarball.
>>
>> Apache MXNet (incubating) community has voted and approved the release.
>>
>> Vote thread:
>> https://lists.apache.org/thread.html/fee7800da4b701cb62d6dd7c1b43ef
>> d44c94a3a386f3adb48f343d6e@%3Cdev.mxnet.apache.org%3E
>>
>> Results thread:
>> https://lists.apache.org/thread.html/0a43205e47a02a528873e16fe0e578
>> 9dfcfebc8a8539f17bbcde2062@%3Cdev.mxnet.apache.org%3E
>>
>> The source tarball, including signatures, digests etc. can be found at:
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc3/
>>
>> The release tag can be found here:
>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3
>>
>> <https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3>
>> The release hash is 297c64fd2ee404612aa3ecc880b940fb2538039c and can be
>> found here:
>> https://github.com/apache/incubator-mxnet/commit/
>> 297c64fd2ee404612aa3ecc880b940fb2538039c
>>
>> <https://github.com/apache/incubator-mxnet/commit/
>> 297c64fd2ee404612aa3ecc880b940fb2538039c>
>> Release artifacts are signed with the following key:
>> 0D04 3D0F 92CA 7333 22A8  D131 9067 CC8E AF55 CD6D
>>
>> KEYS file available:
>>
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>>
>> For information on the contents of the release see:
>>
>> https://cwiki.apache.org/confluence/display/MXNET/
>> Apache+MXNet+%28incubating%29+1.2.0+Release+Notes
>>
>> The vote will end at 1:00 PM on Friday, May 18th, PDT.
>>
>> [ ] +1 Release this package as 1.2.0
>> [ ] +0 no opinion
>> [ ] -1 Do not release this package because ...
>>
>>
>> Anirudh
>>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Posted by Sergio Fernández <wi...@apache.org>.
+1 (binding)

So far I've checked:
* signatures and digests
* source releases file layouts
* matched git tags and commit ids
* incubator suffix and disclaimer
* LICENSE & NOTICE files look good despite the many third-party code (CC-BY
files from RC2 are gone)
* no binary files in the source release
* clean build



On Tue, May 15, 2018 at 12:16 PM, Anirudh Subramanian <
anirudh2290@apache.org> wrote:

> Hi all,
>
> This is a call for releasing Apache MXNet (incubating) 1.2.0, release
> candidate RC3.
> As suggested by Justin and Henri, we have removed the two category b
> license files: DevGuide.md from the release source tarball.
>
> Apache MXNet (incubating) community has voted and approved the release.
>
> Vote thread:
> https://lists.apache.org/thread.html/fee7800da4b701cb62d6dd7c1b43ef
> d44c94a3a386f3adb48f343d6e@%3Cdev.mxnet.apache.org%3E
>
> Results thread:
> https://lists.apache.org/thread.html/0a43205e47a02a528873e16fe0e578
> 9dfcfebc8a8539f17bbcde2062@%3Cdev.mxnet.apache.org%3E
>
> The source tarball, including signatures, digests etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc3/
>
> The release tag can be found here:
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3
>
> <https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3>
> The release hash is 297c64fd2ee404612aa3ecc880b940fb2538039c and can be
> found here:
> https://github.com/apache/incubator-mxnet/commit/
> 297c64fd2ee404612aa3ecc880b940fb2538039c
>
> <https://github.com/apache/incubator-mxnet/commit/
> 297c64fd2ee404612aa3ecc880b940fb2538039c>
> Release artifacts are signed with the following key:
> 0D04 3D0F 92CA 7333 22A8  D131 9067 CC8E AF55 CD6D
>
> KEYS file available:
>
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>
> For information on the contents of the release see:
>
> https://cwiki.apache.org/confluence/display/MXNET/
> Apache+MXNet+%28incubating%29+1.2.0+Release+Notes
>
> The vote will end at 1:00 PM on Friday, May 18th, PDT.
>
> [ ] +1 Release this package as 1.2.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because ...
>
>
> Anirudh
>

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Posted by Anirudh <an...@gmail.com>.
Hi,

Thank you all for voting and providing your inputs.

The vote has passed with three +1 binding votes and no -1 or 0 votes.

+1 (binding):
Sergio
Henri
Sebastian

I will follow up on Monday, on the next steps for the release.

Anirudh


On Sat, May 19, 2018 at 2:08 PM, Sebastian <ss...@apache.org> wrote:

> +1
>
>  - checked signatures
>  - checked building from source under ubuntu 16
>
>
> On 19.05.2018 19:25, Hen wrote:
>
>> I am only reviewing the "diff -r" between RC2 and RC3.
>>
>> Confirmed that the DevGuide.md is removed.
>>
>> There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 )
>> to Dockerfiles, and a pom.xml fix adding a parent tag to the
>> scala-package.
>>
>> These seem fine and rectifies the blocking item in the previous vote.
>>
>> +1.
>>
>> Hen
>>
>>
>> On Tue, May 15, 2018 at 12:16 PM, Anirudh Subramanian <
>> anirudh2290@apache.org> wrote:
>>
>> Hi all,
>>>
>>> This is a call for releasing Apache MXNet (incubating) 1.2.0, release
>>> candidate RC3.
>>> As suggested by Justin and Henri, we have removed the two category b
>>> license files: DevGuide.md from the release source tarball.
>>>
>>> Apache MXNet (incubating) community has voted and approved the release.
>>>
>>> Vote thread:
>>> https://lists.apache.org/thread.html/fee7800da4b701cb62d6dd7c1b43ef
>>> d44c94a3a386f3adb48f343d6e@%3Cdev.mxnet.apache.org%3E
>>>
>>> Results thread:
>>> https://lists.apache.org/thread.html/0a43205e47a02a528873e16fe0e578
>>> 9dfcfebc8a8539f17bbcde2062@%3Cdev.mxnet.apache.org%3E
>>>
>>> The source tarball, including signatures, digests etc. can be found at:
>>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc3/
>>>
>>> The release tag can be found here:
>>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3
>>>
>>> <https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3>
>>> The release hash is 297c64fd2ee404612aa3ecc880b940fb2538039c and can be
>>> found here:
>>> https://github.com/apache/incubator-mxnet/commit/
>>> 297c64fd2ee404612aa3ecc880b940fb2538039c
>>>
>>> <https://github.com/apache/incubator-mxnet/commit/
>>> 297c64fd2ee404612aa3ecc880b940fb2538039c>
>>> Release artifacts are signed with the following key:
>>> 0D04 3D0F 92CA 7333 22A8  D131 9067 CC8E AF55 CD6D
>>>
>>> KEYS file available:
>>>
>>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>>>
>>> For information on the contents of the release see:
>>>
>>> https://cwiki.apache.org/confluence/display/MXNET/
>>> Apache+MXNet+%28incubating%29+1.2.0+Release+Notes
>>>
>>> The vote will end at 1:00 PM on Friday, May 18th, PDT.
>>>
>>> [ ] +1 Release this package as 1.2.0
>>> [ ] +0 no opinion
>>> [ ] -1 Do not release this package because ...
>>>
>>>
>>> Anirudh
>>>
>>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Posted by Sebastian <ss...@apache.org>.
+1

  - checked signatures
  - checked building from source under ubuntu 16

On 19.05.2018 19:25, Hen wrote:
> I am only reviewing the "diff -r" between RC2 and RC3.
> 
> Confirmed that the DevGuide.md is removed.
> 
> There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 )
> to Dockerfiles, and a pom.xml fix adding a parent tag to the scala-package.
> 
> These seem fine and rectifies the blocking item in the previous vote.
> 
> +1.
> 
> Hen
> 
> 
> On Tue, May 15, 2018 at 12:16 PM, Anirudh Subramanian <
> anirudh2290@apache.org> wrote:
> 
>> Hi all,
>>
>> This is a call for releasing Apache MXNet (incubating) 1.2.0, release
>> candidate RC3.
>> As suggested by Justin and Henri, we have removed the two category b
>> license files: DevGuide.md from the release source tarball.
>>
>> Apache MXNet (incubating) community has voted and approved the release.
>>
>> Vote thread:
>> https://lists.apache.org/thread.html/fee7800da4b701cb62d6dd7c1b43ef
>> d44c94a3a386f3adb48f343d6e@%3Cdev.mxnet.apache.org%3E
>>
>> Results thread:
>> https://lists.apache.org/thread.html/0a43205e47a02a528873e16fe0e578
>> 9dfcfebc8a8539f17bbcde2062@%3Cdev.mxnet.apache.org%3E
>>
>> The source tarball, including signatures, digests etc. can be found at:
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc3/
>>
>> The release tag can be found here:
>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3
>>
>> <https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3>
>> The release hash is 297c64fd2ee404612aa3ecc880b940fb2538039c and can be
>> found here:
>> https://github.com/apache/incubator-mxnet/commit/
>> 297c64fd2ee404612aa3ecc880b940fb2538039c
>>
>> <https://github.com/apache/incubator-mxnet/commit/
>> 297c64fd2ee404612aa3ecc880b940fb2538039c>
>> Release artifacts are signed with the following key:
>> 0D04 3D0F 92CA 7333 22A8  D131 9067 CC8E AF55 CD6D
>>
>> KEYS file available:
>>
>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>>
>> For information on the contents of the release see:
>>
>> https://cwiki.apache.org/confluence/display/MXNET/
>> Apache+MXNet+%28incubating%29+1.2.0+Release+Notes
>>
>> The vote will end at 1:00 PM on Friday, May 18th, PDT.
>>
>> [ ] +1 Release this package as 1.2.0
>> [ ] +0 no opinion
>> [ ] -1 Do not release this package because ...
>>
>>
>> Anirudh
>>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

Posted by Hen <ba...@apache.org>.
I am only reviewing the "diff -r" between RC2 and RC3.

Confirmed that the DevGuide.md is removed.

There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 )
to Dockerfiles, and a pom.xml fix adding a parent tag to the scala-package.

These seem fine and rectifies the blocking item in the previous vote.

+1.

Hen


On Tue, May 15, 2018 at 12:16 PM, Anirudh Subramanian <
anirudh2290@apache.org> wrote:

> Hi all,
>
> This is a call for releasing Apache MXNet (incubating) 1.2.0, release
> candidate RC3.
> As suggested by Justin and Henri, we have removed the two category b
> license files: DevGuide.md from the release source tarball.
>
> Apache MXNet (incubating) community has voted and approved the release.
>
> Vote thread:
> https://lists.apache.org/thread.html/fee7800da4b701cb62d6dd7c1b43ef
> d44c94a3a386f3adb48f343d6e@%3Cdev.mxnet.apache.org%3E
>
> Results thread:
> https://lists.apache.org/thread.html/0a43205e47a02a528873e16fe0e578
> 9dfcfebc8a8539f17bbcde2062@%3Cdev.mxnet.apache.org%3E
>
> The source tarball, including signatures, digests etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.2.0.rc3/
>
> The release tag can be found here:
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3
>
> <https://github.com/apache/incubator-mxnet/releases/tag/1.2.0.rc3>
> The release hash is 297c64fd2ee404612aa3ecc880b940fb2538039c and can be
> found here:
> https://github.com/apache/incubator-mxnet/commit/
> 297c64fd2ee404612aa3ecc880b940fb2538039c
>
> <https://github.com/apache/incubator-mxnet/commit/
> 297c64fd2ee404612aa3ecc880b940fb2538039c>
> Release artifacts are signed with the following key:
> 0D04 3D0F 92CA 7333 22A8  D131 9067 CC8E AF55 CD6D
>
> KEYS file available:
>
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>
> For information on the contents of the release see:
>
> https://cwiki.apache.org/confluence/display/MXNET/
> Apache+MXNet+%28incubating%29+1.2.0+Release+Notes
>
> The vote will end at 1:00 PM on Friday, May 18th, PDT.
>
> [ ] +1 Release this package as 1.2.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because ...
>
>
> Anirudh
>