You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/04/06 21:29:44 UTC
Review Request: FLUME-1108: FILE_ROLL sink doesn't accept value 0 for
unlimited wait time before rolling file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4672/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
If rollInterval is set to 0, RollingFileSink does not roll file.
This addresses bug FLUME-1108.
https://issues.apache.org/jira/browse/FLUME-1108
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 7f1d3b3
flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a
Diff: https://reviews.apache.org/r/4672/diff
Testing
-------
Added unit test.
Thanks,
Hari
Re: Review Request: FLUME-1108: FILE_ROLL sink doesn't accept value 0 for
unlimited wait time before rolling file
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4672/#review6753
-----------------------------------------------------------
Ship it!
hmm .. disable rolling for for a component called 'rolling file sink', that's like ordering Ice tea with no ice ;) This probably not be useful in a real production cases, but certainly very handy for testing/validating.
Changes look fine to me.
- Prasad
On 2012-04-06 19:29:44, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4672/
> -----------------------------------------------------------
>
> (Updated 2012-04-06 19:29:44)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> If rollInterval is set to 0, RollingFileSink does not roll file.
>
>
> This addresses bug FLUME-1108.
> https://issues.apache.org/jira/browse/FLUME-1108
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 7f1d3b3
> flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a
>
> Diff: https://reviews.apache.org/r/4672/diff
>
>
> Testing
> -------
>
> Added unit test.
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: FLUME-1108: FILE_ROLL sink doesn't accept value 0 for
unlimited wait time before rolling file
Posted by Will McQueen <wi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4672/#review6770
-----------------------------------------------------------
Ship it!
LGTM!
Yes, I think it would be useful especially in testing scenario. This can be considered the degenerate case, and doesn't affect existing functionality. It's consistent with semantics for other sources/sinks where "0" value is specified. Saves user from needing to enter a high value for rolloverInterval when running multi-day endurance tests.
- Will
On 2012-04-06 19:29:44, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4672/
> -----------------------------------------------------------
>
> (Updated 2012-04-06 19:29:44)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> If rollInterval is set to 0, RollingFileSink does not roll file.
>
>
> This addresses bug FLUME-1108.
> https://issues.apache.org/jira/browse/FLUME-1108
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 7f1d3b3
> flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a
>
> Diff: https://reviews.apache.org/r/4672/diff
>
>
> Testing
> -------
>
> Added unit test.
>
>
> Thanks,
>
> Hari
>
>