You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/03/04 23:49:02 UTC
Review Request 57318: ATALS-1634: added perf trace logs to REST APIs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57318/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1634
https://issues.apache.org/jira/browse/ATLAS-1634
Repository: atlas
Description
-------
added perf trace logging to REST API methods
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 068fdba
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ecb8d30
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 4f7fd0c
webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java c75b596
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java f2d97b3
Diff: https://reviews.apache.org/r/57318/diff/1/
Testing
-------
verified that following logs are generated in atlas_perf.log:
2017-03-04 14:07:33,621|pool-1-thread-10 - c2ad7fa0-d628-4860-a14b-b227c885dd73|PERF|DiscoveryREST.searchUsingBasic(null,null,PII,25,0)|257
2017-03-04 14:07:45,016|pool-1-thread-7 - 671a48e9-89e6-4b17-a097-7222fca834d4|PERF|EntityREST.getById(a37023ed-7fce-4279-a106-633e80e062ac)|20
2017-03-04 14:07:45,120|pool-1-thread-10 - a8b9bef2-5535-48e5-b38b-56b874f6ab1b|PERF|EntityResource.getAuditEvents(a37023ed-7fce-4279-a106-633e80e062ac, null, 26)|20
2017-03-04 14:07:45,432|pool-1-thread-5 - 14860a2e-6db2-4ffa-bbfe-2cbeb5090679|PERF|LineageREST.getLineageGraph(a37023ed-7fce-4279-a106-633e80e062ac,BOTH,3)|370
2017-03-04 14:08:05,456|pool-1-thread-4 - 54c8d6e1-ecd0-486f-8424-0d753f8bfbdd|PERF|EntityREST.addClassification(ClassificationAssociateRequest{classification='AtlasStruct{typeName='Fact', attributes=[]}, entityGuids=[a37023ed-7fce-4279-a106-633e80e062ac]})|1217
2017-03-04 14:08:05,470|pool-1-thread-6 - 1d6a6e10-b0c7-4894-8463-4206a6a2e140|PERF|EntityREST.getById(a37023ed-7fce-4279-a106-633e80e062ac)|3
2017-03-04 14:08:05,493|pool-1-thread-8 - 891a566a-c667-493d-bd63-bfd96941cd84|PERF|EntityResource.getAuditEvents(a37023ed-7fce-4279-a106-633e80e062ac, null, 26)|7
Thanks,
Madhan Neethiraj
Re: Review Request 57318: ATALS-1634: added perf trace logs to REST
APIs
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57318/#review167937
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On March 4, 2017, 11:49 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57318/
> -----------------------------------------------------------
>
> (Updated March 4, 2017, 11:49 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1634
> https://issues.apache.org/jira/browse/ATLAS-1634
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added perf trace logging to REST API methods
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 068fdba
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ecb8d30
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 4f7fd0c
> webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java c75b596
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java f2d97b3
>
>
> Diff: https://reviews.apache.org/r/57318/diff/1/
>
>
> Testing
> -------
>
> verified that following logs are generated in atlas_perf.log:
>
> 2017-03-04 14:07:33,621|pool-1-thread-10 - c2ad7fa0-d628-4860-a14b-b227c885dd73|PERF|DiscoveryREST.searchUsingBasic(null,null,PII,25,0)|257
> 2017-03-04 14:07:45,016|pool-1-thread-7 - 671a48e9-89e6-4b17-a097-7222fca834d4|PERF|EntityREST.getById(a37023ed-7fce-4279-a106-633e80e062ac)|20
> 2017-03-04 14:07:45,120|pool-1-thread-10 - a8b9bef2-5535-48e5-b38b-56b874f6ab1b|PERF|EntityResource.getAuditEvents(a37023ed-7fce-4279-a106-633e80e062ac, null, 26)|20
> 2017-03-04 14:07:45,432|pool-1-thread-5 - 14860a2e-6db2-4ffa-bbfe-2cbeb5090679|PERF|LineageREST.getLineageGraph(a37023ed-7fce-4279-a106-633e80e062ac,BOTH,3)|370
> 2017-03-04 14:08:05,456|pool-1-thread-4 - 54c8d6e1-ecd0-486f-8424-0d753f8bfbdd|PERF|EntityREST.addClassification(ClassificationAssociateRequest{classification='AtlasStruct{typeName='Fact', attributes=[]}, entityGuids=[a37023ed-7fce-4279-a106-633e80e062ac]})|1217
> 2017-03-04 14:08:05,470|pool-1-thread-6 - 1d6a6e10-b0c7-4894-8463-4206a6a2e140|PERF|EntityREST.getById(a37023ed-7fce-4279-a106-633e80e062ac)|3
> 2017-03-04 14:08:05,493|pool-1-thread-8 - 891a566a-c667-493d-bd63-bfd96941cd84|PERF|EntityResource.getAuditEvents(a37023ed-7fce-4279-a106-633e80e062ac, null, 26)|7
>
>
> Thanks,
>
> Madhan Neethiraj
>
>