You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jaredstehler (via GitHub)" <gi...@apache.org> on 2023/11/14 16:26:21 UTC
[PR] [MNG-5378] configure strict artifact descriptor policy via property [maven]
jaredstehler opened a new pull request, #1304:
URL: https://github.com/apache/maven/pull/1304
This adds a mechanism for setting a strict artifact descriptor policy, via a boolean config property: `aether.artifactDescriptorPolicy.strict`.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-5378] configure strict artifact descriptor policy via property [maven]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1304:
URL: https://github.com/apache/maven/pull/1304#discussion_r1393839606
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -373,6 +375,12 @@ public DefaultRepositorySystemSession newRepositorySession(MavenExecutionRequest
session.getRepositoryListener(), new ReverseTreeRepositoryListener()));
}
+ boolean strictDescriptorPolicy =
+ ConfigUtils.getBoolean(session, false, "aether.artifactDescriptorPolicy.strict");
Review Comment:
why not something like `maven....` for this property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7933] configure strict artifact descriptor policy via property [maven]
Posted by "jaredstehler (via GitHub)" <gi...@apache.org>.
jaredstehler commented on PR #1304:
URL: https://github.com/apache/maven/pull/1304#issuecomment-1812673242
> @jaredstehler I'd like to propose to have this PR superseded by "onSessionClose" that contains a bunch of maven+resolver improvements, for example this one (contains your change but exposed via CLI): [e93bb72](https://github.com/apache/maven/commit/e93bb7293792cd68569060b51074b95d6ccb795a)
that looks perfect, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7933] configure strict artifact descriptor policy via property [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1304:
URL: https://github.com/apache/maven/pull/1304#issuecomment-1858942398
Is this PR still needed? Please close it out if not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7933] configure strict artifact descriptor policy via property [maven]
Posted by "jaredstehler (via GitHub)" <gi...@apache.org>.
jaredstehler closed pull request #1304: [MNG-7933] configure strict artifact descriptor policy via property
URL: https://github.com/apache/maven/pull/1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-5378] configure strict artifact descriptor policy via property [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1304:
URL: https://github.com/apache/maven/pull/1304#issuecomment-1812161662
@jaredstehler I'd like to propose to have this PR superseded by "onSessionClose" that contains a bunch of maven+resolver improvements, for example this one (contains your change but exposed via CLI): https://github.com/apache/maven/pull/1301/commits/e93bb7293792cd68569060b51074b95d6ccb795a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7933] configure strict artifact descriptor policy via property [maven]
Posted by "jaredstehler (via GitHub)" <gi...@apache.org>.
jaredstehler commented on code in PR #1304:
URL: https://github.com/apache/maven/pull/1304#discussion_r1394321352
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -373,6 +375,12 @@ public DefaultRepositorySystemSession newRepositorySession(MavenExecutionRequest
session.getRepositoryListener(), new ReverseTreeRepositoryListener()));
}
+ boolean strictDescriptorPolicy =
+ ConfigUtils.getBoolean(session, false, "aether.artifactDescriptorPolicy.strict");
Review Comment:
i was just following conventions for setting aether / resolver properties from here: https://maven.apache.org/resolver/configuration.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org