You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ta...@apache.org on 2021/08/24 04:04:45 UTC
[hbase] branch HBASE-25853 updated: HBASE-26134 Backport
HBASE-25617 "Revisit the span names" to branch-2 (#3618)
This is an automated email from the ASF dual-hosted git repository.
taklwu pushed a commit to branch HBASE-25853
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/HBASE-25853 by this push:
new 5de0ef3 HBASE-26134 Backport HBASE-25617 "Revisit the span names" to branch-2 (#3618)
5de0ef3 is described below
commit 5de0ef3c28ef5d19086f91a5b6dff441ea4fae66
Author: Tak Lon (Stephen) Wu <ta...@apache.org>
AuthorDate: Mon Aug 23 21:04:16 2021 -0700
HBASE-26134 Backport HBASE-25617 "Revisit the span names" to branch-2 (#3618)
11/17 commits of HBASE-22120, original commit 8d68f8cd1c8613be1b499eaa99f46806b2743294
Co-authored-by: Duo Zhang <zh...@apache.org>
Signed-off-by: Duo Zhang <zh...@apache.org>
---
.../main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java | 4 ++--
.../main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java | 2 +-
.../main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
index 05c2099e..4143173 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
@@ -386,12 +386,12 @@ class AsyncConnectionImpl implements AsyncConnection {
}
});
return future;
- }, getClass().getName() + ".getHbck");
+ }, "AsyncConnection.getHbck");
}
@Override
public Hbck getHbck(ServerName masterServer) throws IOException {
- Span span = TraceUtil.createSpan(getClass().getName() + ".getHbck")
+ Span span = TraceUtil.createSpan("AsyncConnection.getHbck")
.setAttribute(TraceUtil.SERVER_NAME_KEY, masterServer.getServerName());
try (Scope scope = span.makeCurrent()) {
// we will not create a new connection when creating a new protobuf stub, and for hbck there
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java
index 3067785..61086c4 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java
@@ -97,7 +97,7 @@ class AsyncRegionLocator {
private <T> CompletableFuture<T> tracedLocationFuture(Supplier<CompletableFuture<T>> action,
Function<T, List<String>> getRegionNames, TableName tableName, String methodName) {
- Span span = createTableSpan(getClass().getSimpleName() + "." + methodName, tableName);
+ Span span = createTableSpan("AsyncRegionLocator." + methodName, tableName);
try (Scope scope = span.makeCurrent()) {
CompletableFuture<T> future = action.get();
FutureUtils.addListener(future, (resp, error) -> {
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java
index 627e8d2..23bd333 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java
@@ -307,6 +307,6 @@ public class ConnectionFactory {
}
});
return future;
- }, ConnectionFactory.class.getSimpleName() + ".createAsyncConnection");
+ }, "ConnectionFactory.createAsyncConnection");
}
}