You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/08/28 02:44:44 UTC
[jira] Created: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Erlang assumes that field types are correct and de-synchronizes if they are not
-------------------------------------------------------------------------------
Key: THRIFT-127
URL: https://issues.apache.org/jira/browse/THRIFT-127
Project: Thrift
Issue Type: Bug
Reporter: David Reiss
Assignee: David Reiss
Priority: Minor
Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688495#action_12688495 ]
Bryan Duxbury commented on THRIFT-127:
--------------------------------------
What are we waiting on to commit this?
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626396#action_12626396 ]
Todd Lipcon commented on THRIFT-127:
------------------------------------
Two comments:
1) Do other languages support sloppiness between int types? It seems to me that if you change an i32 to an i64 for example, it should allow it (possibly with a warning) given erlang ints don't have sizes. If we're worried about overflow in dependent parts of the system, we could allow the sloppiness only in the upward direction (e.g. receiving an i32 when you expect an i64 isn't a problem).
2) Line 150: FTypeAtom = thrift_protocol:typeid_to_atom(FType) is now redundant with Type.
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-127:
-------------------------------
Patch Info: [Patch Available]
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-127.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.1
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688834#action_12688834 ]
David Reiss commented on THRIFT-127:
------------------------------------
A review from one of the other Erlang devs. Preferably Todd.
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669129#action_12669129 ]
David Reiss commented on THRIFT-127:
------------------------------------
Any chance I can get a second look at this? It is still a fairly small patch (minus indentation changes and pulling out a new function). The current version doesn't allow integer promotion, so I don't think I'm breaking anything.
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (THRIFT-127) Erlang assumes that field types
are correct and de-synchronizes if they are not
Posted by Eugene Letuchy <el...@facebook.com>.
Looks good to me. Would it be possible to add a comments to the
test_membuffer.erl cases that indicate what each test case is testing for?
- Eugene
On 1/29/09 4:14 PM, David Reiss (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> David Reiss updated THRIFT-127:
> -------------------------------
>
> Attachment: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>> Erlang assumes that field types are correct and de-synchronizes if they are not
>> -------------------------------------------------------------------------------
>>
>> Key: THRIFT-127
>> URL: https://issues.apache.org/jira/browse/THRIFT-127
>> Project: Thrift
>> Issue Type: Bug
>> Components: Library (Erlang)
>> Reporter: David Reiss
>> Assignee: David Reiss
>> Priority: Minor
>> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>>
>>
>> Patch in a moment.
>
[jira] Updated: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-127:
-------------------------------
Attachment: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "Eugene Letuchy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693795#action_12693795 ]
Eugene Letuchy commented on THRIFT-127:
---------------------------------------
The patch is fine. Two minor quibbles:
1/ I'd rename _Else3 to _Else2 (or just _).
2/ The message "Skipping fid ~p", just after the diff'd portion, needs to be sync'ed with "Skipping field ~p" and should likely have a reason provided as part of the message.
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626390#action_12626390 ]
David Reiss commented on THRIFT-127:
------------------------------------
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d6c2991
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-127:
-------------------------------
Component/s: Library (Erlang)
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-127) Erlang assumes that field types are
correct and de-synchronizes if they are not
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626415#action_12626415 ]
David Reiss commented on THRIFT-127:
------------------------------------
1/ No, other languages don't support that sloppiness. Implementing it would require implementing casting rules, which is yucky.
2/ Made irrelevant by changes.
The first version didn't actually work. Trying again.
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=46a0840
> Erlang assumes that field types are correct and de-synchronizes if they are not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.