You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/16 04:09:31 UTC

[GitHub] [pulsar] WJL3333 opened a new pull request, #18058: [fix][client][txn] Use PulsarClient HashWheelTimer to schedule producer batch trigger task

WJL3333 opened a new pull request, #18058:
URL: https://github.com/apache/pulsar/pull/18058

   fix when create a lot of producer (> 10000) in the same jvm which will use eventLoop to do task check
   
   Fixes #18055
   
   
   ### Motivation
   
   when broker own a lot of topic ( > 10000 ) and enable txn. 
   the producer create for `TransactionBufferSystemTopicClient` enable batch for current code.
   which will use broker workerGroup thread to schedule batch check task. which will cause high cpu usage.
   
   ### Modifications
   
   use client HashWheelTimer for schedule batch check task and when trigger task execute on pulsarClient internalExecutorPool
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [x] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #18058: [fix][client][txn] Use PulsarClient HashWheelTimer to schedule producer batch trigger task

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #18058:
URL: https://github.com/apache/pulsar/pull/18058#issuecomment-1279969818

   Please send the patch against the master branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall merged pull request #18058: [fix][client][txn] Use PulsarClient HashWheelTimer to schedule producer batch trigger task

Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #18058:
URL: https://github.com/apache/pulsar/pull/18058


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #18058: [fix][client][txn] Use PulsarClient HashWheelTimer to schedule producer batch trigger task

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #18058:
URL: https://github.com/apache/pulsar/pull/18058#issuecomment-1280263582

   @eolivelli - I merged this PR because master has diverged a bit, so cherry picking the PR from master to 2.9 would not have been easy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org