You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/17 03:50:08 UTC
Review Request 12620: Updated process.cpp to use os::sendfile.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12620/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-508
https://issues.apache.org/jira/browse/MESOS-508
Repository: mesos-git
Description
-------
See above.
Diffs
-----
3rdparty/libprocess/src/config.hpp 1daa47662db8dffe68655380ee73d07ac3527ba1
3rdparty/libprocess/src/process.cpp 08242ced05a2d8004b818b4952194f0aa66b4fcb
Diff: https://reviews.apache.org/r/12620/diff/
Testing
-------
A little tricky to test, I've ensured the webui can serve files, and added a test in the subsequent review of this chain.
Thanks,
Ben Mahler
Re: Review Request 12620: Updated process.cpp to use os::sendfile.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12620/
-----------------------------------------------------------
(Updated Aug. 3, 2013, 1:10 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Only a rebase.
Bugs: MESOS-508
https://issues.apache.org/jira/browse/MESOS-508
Repository: mesos-git
Description
-------
See above.
Diffs (updated)
-----
3rdparty/libprocess/src/config.hpp 1daa47662db8dffe68655380ee73d07ac3527ba1
3rdparty/libprocess/src/process.cpp 443acfd00705b754dfd177805957bcc7b10101ee
Diff: https://reviews.apache.org/r/12620/diff/
Testing
-------
A little tricky to test, I've ensured the webui can serve files, and added a test in the subsequent review of this chain.
Thanks,
Ben Mahler
Re: Review Request 12620: Updated process.cpp to use os::sendfile.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12620/#review24251
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 17, 2013, 1:50 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12620/
> -----------------------------------------------------------
>
> (Updated July 17, 2013, 1:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-508
> https://issues.apache.org/jira/browse/MESOS-508
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/config.hpp 1daa47662db8dffe68655380ee73d07ac3527ba1
> 3rdparty/libprocess/src/process.cpp 08242ced05a2d8004b818b4952194f0aa66b4fcb
>
> Diff: https://reviews.apache.org/r/12620/diff/
>
>
> Testing
> -------
>
> A little tricky to test, I've ensured the webui can serve files, and added a test in the subsequent review of this chain.
>
>
> Thanks,
>
> Ben Mahler
>
>