You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "yaalsn (via GitHub)" <gi...@apache.org> on 2023/11/25 09:34:06 UTC
[PR] [fix][client] Exit when no msg to consume if time reaches the limit [pulsar]
yaalsn opened a new pull request, #21622:
URL: https://github.com/apache/pulsar/pull/21622
### Motivation
If there's no message to consume, the listener won't be invoked, so the main thread will still run in the loop even if time reaches the limit.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Exit when no msg to consume if time reaches the limit [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on code in PR #21622:
URL: https://github.com/apache/pulsar/pull/21622#discussion_r1405964145
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java:
##########
@@ -247,13 +247,6 @@ public static void main(String[] args) throws Exception {
Semaphore messageReceiveLimiter = new Semaphore(arguments.numMessagesPerTransaction);
Thread thread = Thread.currentThread();
MessageListener<ByteBuffer> listener = (consumer, msg) -> {
- if (arguments.testTime > 0) {
- if (System.nanoTime() > testEndTime) {
- log.info("------------------- DONE -----------------------");
- PerfClientUtils.exit(0);
- thread.interrupt();
- }
- }
if (arguments.totalNumTxn > 0) {
Review Comment:
This should be kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Exit when no msg to consume if time reaches the limit [pulsar]
Posted by "yaalsn (via GitHub)" <gi...@apache.org>.
yaalsn commented on code in PR #21622:
URL: https://github.com/apache/pulsar/pull/21622#discussion_r1407083110
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java:
##########
@@ -505,6 +506,14 @@ public static void main(String[] args) throws Exception {
reportHistogram.reset();
oldTime = now;
+
+ if (arguments.testTime > 0) {
+ if (now > testEndTime) {
+ log.info("------------------- DONE -----------------------");
+ PerfClientUtils.exit(0);
+ thread.interrupt();
Review Comment:
Good catch, I'll remove the lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Exit when no msg to consume if time reaches the limit [pulsar]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on code in PR #21622:
URL: https://github.com/apache/pulsar/pull/21622#discussion_r1406988205
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java:
##########
@@ -505,6 +506,14 @@ public static void main(String[] args) throws Exception {
reportHistogram.reset();
oldTime = now;
+
+ if (arguments.testTime > 0) {
+ if (now > testEndTime) {
+ log.info("------------------- DONE -----------------------");
+ PerfClientUtils.exit(0);
+ thread.interrupt();
Review Comment:
`thread.interrupt()` this line should never be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Exit when no msg to consume if time reaches the limit [pulsar]
Posted by "yaalsn (via GitHub)" <gi...@apache.org>.
yaalsn commented on code in PR #21622:
URL: https://github.com/apache/pulsar/pull/21622#discussion_r1405975598
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java:
##########
@@ -247,13 +247,6 @@ public static void main(String[] args) throws Exception {
Semaphore messageReceiveLimiter = new Semaphore(arguments.numMessagesPerTransaction);
Thread thread = Thread.currentThread();
MessageListener<ByteBuffer> listener = (consumer, msg) -> {
- if (arguments.testTime > 0) {
- if (System.nanoTime() > testEndTime) {
- log.info("------------------- DONE -----------------------");
- PerfClientUtils.exit(0);
- thread.interrupt();
- }
- }
if (arguments.totalNumTxn > 0) {
Review Comment:
Make sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Exit when no msg to consume if time reaches the limit [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #21622:
URL: https://github.com/apache/pulsar/pull/21622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org