You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/22 07:26:34 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10320: [Tests] Improve integration test logging to improve readability and efficiency

lhotari opened a new pull request #10320:
URL: https://github.com/apache/pulsar/pull/10320


   ### Motivation
   
   Integration tests log /var/log/pulsar/*.log files in an inefficient way. It buffers the output in memory beside logging. When the container terminates, the buffered content is also written to the log output. This is confusing and inefficient.
   Building a large StringBuffer in memory causes a lot of GC churn.
   
   ### Modifications
   
   - refactor DockerUtils used in integration tests
   - add new method `runCommandAsyncWithLogging` which doesn't buffer to memory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10320: [Tests] Improve integration test logging to improve readability and efficiency

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10320:
URL: https://github.com/apache/pulsar/pull/10320


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10320: [Tests] Improve integration test logging to improve readability and efficiency

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10320:
URL: https://github.com/apache/pulsar/pull/10320#issuecomment-826352022


   @aahmed-se @merlimat please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10320: [Tests] Improve integration test logging to improve readability and efficiency

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10320:
URL: https://github.com/apache/pulsar/pull/10320


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10320: [Tests] Improve integration test logging to improve readability and efficiency

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10320:
URL: https://github.com/apache/pulsar/pull/10320#issuecomment-826352022


   @aahmed-se @merlimat please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10320: [Tests] Improve integration test logging to improve readability and efficiency

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10320:
URL: https://github.com/apache/pulsar/pull/10320#issuecomment-824964304


   @aahmed-se @eolivelli Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org