You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2023/06/21 13:12:24 UTC
[GitHub] [doris] CalvinKirs opened a new pull request, #21088: [Chore](script)Remove redundant Clang checks
CalvinKirs opened a new pull request, #21088:
URL: https://github.com/apache/doris/pull/21088
Clang/GCC has already been checked in Cmake, so there is no need to check again in env.sh
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21088: [Chore](script)Remove redundant Clang checks
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21088:
URL: https://github.com/apache/doris/pull/21088#issuecomment-1600812876
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5334535284") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In env.sh line 118:
if [[ "${ENABLE_PCH}" == "ON" ]]; then
^-----------^ SC2154 (warning): ENABLE_PCH is referenced but not assigned.
In thirdparty/build-thirdparty.sh line 155:
if [[ "${CC}" == *gcc ]]; then
^---^ SC2154 (warning): CC is referenced but not assigned.
For more information:
https://www.shellcheck.net/wiki/SC2154 -- CC is referenced but not assigned.
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs closed pull request #21088: [Chore](script)Remove redundant Clang checks
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs closed pull request #21088: [Chore](script)Remove redundant Clang checks
URL: https://github.com/apache/doris/pull/21088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org