[GitHub] spark pull request #15826: [SPARK-14077][ML][FOLLOW-UP] Minor refactor and c...

[yanboliang <gi...@git.apache.org>]

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15826#discussion_r87152501
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
    @@ -226,13 +206,33 @@ class NaiveBayes @Since("1.5.0") (
     @Since("1.6.0")
     object NaiveBayes extends DefaultParamsReadable[NaiveBayes] {
       /** String name for multinomial model type. */
    -  private[spark] val Multinomial: String = "multinomial"
    +  private[classification] val Multinomial: String = "multinomial"
     
       /** String name for Bernoulli model type. */
    -  private[spark] val Bernoulli: String = "bernoulli"
    +  private[classification] val Bernoulli: String = "bernoulli"
     
       /* Set of modelTypes that NaiveBayes supports */
    -  private[spark] val supportedModelTypes = Set(Multinomial, Bernoulli)
    +  private[classification] val supportedModelTypes = Set(Multinomial, Bernoulli)
    +
    +  private[NaiveBayes] val requireNonnegativeValues: Vector => Unit = (v: Vector) => {
    --- End diff --
    
    @thunterdb I define these two functions still by ```val``` which should be more appropriate, since there is difference between ```val``` and ```def``` to define a function. http://stackoverflow.com/questions/18887264/what-is-the-difference-between-def-and-val-to-define-a-function


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org