You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/02/14 13:45:27 UTC
Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases for
Multiple IPs per NIC feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding first set of test cases for feature "Multiple IPs per NICs".
Diffs
-----
test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
tools/marvin/marvin/codes.py 74fb05d
tools/marvin/marvin/integration/lib/base.py aa23029
tools/marvin/marvin/integration/lib/common.py e202391
Diff: https://reviews.apache.org/r/18117/diff/
Testing
-------
Yes
Thanks,
Ashutosh Kelkar
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34656
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 1:20 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
> Remove invalid ip ... ok
> test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
>
> ----------------------------------------------------------------------
> Ran 13 tests in 4170.915s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34687
-----------------------------------------------------------
Commit c8422b3b50769b4064e7a497b0b6cd09a736fd26 in cloudstack's branch refs/heads/4.3-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8422b3 ]
CLOUDSTACK-4840: Adding first set of test cases for Multiple IPs per NIC feature
- ASF Subversion and Git Services
On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 1:20 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
> Remove invalid ip ... ok
> test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
>
> ----------------------------------------------------------------------
> Ran 13 tests in 4170.915s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34686
-----------------------------------------------------------
Commit 860b02095087d5b8a6a32efd46992f89c1aa4c05 in cloudstack's branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=860b020 ]
CLOUDSTACK-4840: Adding first set of test cases for Multiple IPs per NIC feature
- ASF Subversion and Git Services
On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 1:20 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
> Remove invalid ip ... ok
> test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
>
> ----------------------------------------------------------------------
> Ran 13 tests in 4170.915s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34845
-----------------------------------------------------------
Commit 6db3cb26184e0209fde41cbbc3aba6ac9950823f in cloudstack's branch refs/heads/4.3-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6db3cb2 ]
CLOUDSTACK-4840: Add missed testcase in previous commit
- ASF Subversion and Git Services
On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 1:20 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
> Remove invalid ip ... ok
> test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
>
> ----------------------------------------------------------------------
> Ran 13 tests in 4170.915s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34846
-----------------------------------------------------------
Commit b70af44ecfb0b7509a456327d85b5c0aea1ed197 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b70af44 ]
CLOUDSTACK-4840: Add missed testcase in previous commit
- ASF Subversion and Git Services
On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 1:20 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
> Remove invalid ip ... ok
> test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
>
> ----------------------------------------------------------------------
> Ran 13 tests in 4170.915s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 1:20 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding first set of test cases for feature "Multiple IPs per NICs".
Diffs (updated)
-----
test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
tools/marvin/marvin/codes.py 74fb05d
tools/marvin/marvin/integration/lib/base.py aa23029
tools/marvin/marvin/integration/lib/common.py e202391
Diff: https://reviews.apache.org/r/18117/diff/
Testing (updated)
-------
test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
Add secondary IP to NIC of a VM ... ok
test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
Add secondary IP to NIC of a VM ... ok
test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
Add secondary IP to NIC of a VM ... ok
test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
Test listing nics associated with the ip address ... ok
test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
Test listing nics associated with the ip address ... ok
test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
Test listing nics associated with the ip address ... ok
test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
Test basic operations using non root admin apii client ... ok
test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
Test basic operations using non root admin apii client ... ok
test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
Test basic operations using non root admin apii client ... ok
test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
Remove invalid ip ... ok
test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
Remove secondary IP from NIC of a VM ... ok
test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
Remove secondary IP from NIC of a VM ... ok
test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
Remove secondary IP from NIC of a VM ... ok
----------------------------------------------------------------------
Ran 13 tests in 4170.915s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 17, 2014, 8:49 a.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/integration/lib/common.py, line 937
> > <https://reviews.apache.org/r/18117/diff/2/?file=485190#file485190line937>
> >
> > All other seems to be ok, only one request here is not to raise asserts in library method, use try\except block and assert in the test case based upon outcome.
> > Also, please attach test case run log.
Added log and separated the assertions in the test case instead of in library method.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34639
-----------------------------------------------------------
On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 1:20 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Add secondary IP to NIC of a VM ... ok
> test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test listing nics associated with the ip address ... ok
> test_operations_non_root_admin_api_client_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_operations_non_root_admin_api_client_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Test basic operations using non root admin apii client ... ok
> test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations)
> Remove invalid ip ... ok
> test_remove_ip_from_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
> test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations)
> Remove secondary IP from NIC of a VM ... ok
>
> ----------------------------------------------------------------------
> Ran 13 tests in 4170.915s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34639
-----------------------------------------------------------
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/18117/#comment64831>
All other seems to be ok, only one request here is not to raise asserts in library method, use try\except block and assert in the test case based upon outcome.
Also, please attach test case run log.
- Santhosh Edukulla
On Feb. 14, 2014, 1:01 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 1:01 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding first set of test cases for feature "Multiple IPs per NICs".
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
> tools/marvin/marvin/codes.py 74fb05d
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/18117/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases
for Multiple IPs per NIC feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/
-----------------------------------------------------------
(Updated Feb. 14, 2014, 1:01 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-4840
https://issues.apache.org/jira/browse/CLOUDSTACK-4840
Repository: cloudstack-git
Description
-------
Adding first set of test cases for feature "Multiple IPs per NICs".
Diffs (updated)
-----
test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION
tools/marvin/marvin/codes.py 74fb05d
tools/marvin/marvin/integration/lib/base.py aa23029
tools/marvin/marvin/integration/lib/common.py e202391
Diff: https://reviews.apache.org/r/18117/diff/
Testing
-------
Yes
Thanks,
Ashutosh Kelkar