[GitHub] [calcite] julianhyde commented on issue #1246: [CALCITE-2968] New AntiJoin relational expression

[GitBox <gi...@apache.org>]

julianhyde commented on issue #1246: [CALCITE-2968] New AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#issuecomment-499241738
 
 
   Regarding `isSemiOrAntiJoin` and `projectsRight`. I saw one or places in the code where I thought it would be more natural to write
   ```
   switch (join.getJoinType) {
   case SEMI:
   case ANTI:
     ...
   ```
   than to write
   ```
   if (join.projectsRight()) {
     ...
   ```
   
   I encourage people to use a `switch` on join types if is easier to comprehend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services