You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "josedee (via GitHub)" <gi...@apache.org> on 2025/04/25 16:00:29 UTC

[PR] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

josedee opened a new pull request, #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904

   Closes https://github.com/apache/incubator-kie-issues/issues/1932
   
   Added default name for ThrowLink and CatchLink nodes
   
   <img width="1314" alt="Screenshot 2025-04-25 at 9 20 44 PM" src="https://github.com/user-attachments/assets/f910437d-9197-4c3a-8f00-f9d9ff78860b" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904#issuecomment-2831089204

   
   **PR job** `#1` was: **UNSTABLE**
   Possible explanation: This should be test failures
   
   
   <details>
   <summary><b>Reproducer</b></summary>
   
   
   
   build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904 --skipParallelCheckout
   
   NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
   
   </details>
   
   
   Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/display/redirect
   
   **Test results:**
   - PASSED: 3552
   - FAILED: 29
   
   Those are the test failures: 
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[37]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[37]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[39]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[39]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[40]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[40]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[41]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[41]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[48]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[48]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[50]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[50]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[54]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[54]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[57]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[57]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[60]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[60]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[61]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[61]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[62]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[62]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[63]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[63]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[64]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[64]</a></summary>
   [BoundaryEventNode] nodes with name [BoundaryEvent] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[65]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[65]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[67]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[67]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[69]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[69]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[70]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[70]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[71]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[71]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[72]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[72]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[73]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[73]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[74]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[74]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[75]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[75]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[76]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[76]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[77]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[77]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[78]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[78]</a></summary>
   [DynamicNode] nodes with name [Dynamic] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[81]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[81]</a></summary>
   [StartNode] nodes with name [Start] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[127]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[127]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[130]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[130]</a></summary>
   [EndNode] nodes with name [End] are not equal
   </details>
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/1/testReport/org.kie.kogito.codegen.tests/PublishEventIT/testBasicCallActivityTask/">org.kie.kogito.codegen.tests.PublishEventIT.testBasicCallActivityTask</a></summary>
   Cannot invoke "String.equals(Object)" because the return value of "org.kie.kogito.event.DataEvent.getKogitoProcessId()" is null
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [Incubator-kie-issues-1932] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on code in PR #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904#discussion_r2066982798


##########
kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/process/ProcessGenerationIT.java:
##########
@@ -204,7 +204,7 @@ private static void assertNodes(Node[] expected, Node[] current) {
 
     private static final BiConsumer<Node, Node> nodeAsserter = (expected, current) -> {
         assertThat(current.getId()).isEqualTo(expected.getId());
-        if (expected.getName() != null) {
+        if (expected.getName() != null && !expected.getName().trim().isEmpty()) {

Review Comment:
   Maybe we could use `StringUtils.isBlank` here like:
   ```suggestion
           if (!StringUtils.isBlank(expected.getName()) {
   ) {
   ```
   
   But I'm ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904#issuecomment-2835878018

   
   **PR job** `#3` was: **UNSTABLE**
   Possible explanation: This should be test failures
   
   
   <details>
   <summary><b>Reproducer</b></summary>
   
   
   
   build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904 --skipParallelCheckout
   
   NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
   
   </details>
   
   
   Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/3/display/redirect
   
   **Test results:**
   - PASSED: 3579
   - FAILED: 1
   
   Those are the test failures: 
   <details>
   <summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3904/3/testReport/org.kie.kogito.quarkus.workflows/PojoServiceIT/testPojo/">org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo</a></summary>
   <br/>Expected size: 1 but was: 2 in:<br/>{"age"=666, "name"="javierito"}
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [Incubator-kie-issues-1932] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian merged PR #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [Incubator-kie-issues-1932] Fix for node name being null for throw and catch link [incubator-kie-kogito-runtimes]

Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on code in PR #3904:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3904#discussion_r2066976577


##########
kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/process/ProcessGenerationIT.java:
##########
@@ -204,7 +204,7 @@ private static void assertNodes(Node[] expected, Node[] current) {
 
     private static final BiConsumer<Node, Node> nodeAsserter = (expected, current) -> {
         assertThat(current.getId()).isEqualTo(expected.getId());
-        if (expected.getName() != null) {
+        if (expected.getName() != null && !expected.getName().trim().isEmpty()) {

Review Comment:
   Maybe we could use `StringUtils.isBlank` here like:
   ```suggestion
           if (!StringUtils.isBlank(expected.getName()) {
   ) {
   ```
   
   But I'm ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org