You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/14 08:02:38 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request, #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type

AngersZhuuuu opened a new pull request, #37190:
URL: https://github.com/apache/spark/pull/37190

   
   ### What changes were proposed in this pull request?
   The current verbose string of LogicalPlan didn't contain join type, we should add this
   ```
   (10) BroadcastHashJoin [codegen id : 4]
   Left keys [1]: [ws_sold_date_sk#7]
   Right keys [1]: [d_date_sk#9]
   Join type: Inner
   Join condition: None
   ```
   
   
   
   ### Why are the changes needed?
   Add missed join type in verbose plan
   
   
   ### Does this PR introduce _any_ user-facing change?
   User can see join type in verbose plan string
   
   ### How was this patch tested?
   Existed UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #37190: [SPARK-39776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37190:
URL: https://github.com/apache/spark/pull/37190#issuecomment-1202245812

   TPC-DS plain stability test fails _I think_ after this PR (when ANSI is enabled) https://github.com/apache/spark/runs/7511882605?check_suite_focus=true
   
   @AngersZhuuuu would you mind taking a look when you find some time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37190:
URL: https://github.com/apache/spark/pull/37190#issuecomment-1193715455

   @AngersZhuuuu the JIRA ID is wrong...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #37190:
URL: https://github.com/apache/spark/pull/37190#issuecomment-1193608415

   @cloud-fan the failed GA seems not related to this patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type
URL: https://github.com/apache/spark/pull/37190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #37190:
URL: https://github.com/apache/spark/pull/37190#issuecomment-1184137438

   ping @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #37190: [SPARK-39776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #37190:
URL: https://github.com/apache/spark/pull/37190#issuecomment-1193773752

   > @AngersZhuuuu the JIRA ID is wrong...
   
   updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #37190: [SPARK-399776][SQL] JOIN verbose string should add Join type

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37190:
URL: https://github.com/apache/spark/pull/37190#issuecomment-1193714430

   failed GA job is unrelated to this PR, merging to master, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org