You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/26 05:17:23 UTC
[GitHub] [incubator-mxnet] xinyu-intel commented on a change in pull request
#14608: [MKLDNN]Refactor requantize to speed up execution
xinyu-intel commented on a change in pull request #14608: [MKLDNN]Refactor requantize to speed up execution
URL: https://github.com/apache/incubator-mxnet/pull/14608#discussion_r278810732
##########
File path: src/operator/quantization/mkldnn/mkldnn_requantize-inl.h
##########
@@ -99,55 +108,47 @@ static void MKLDNNRequantizeForward(const nnvm::NodeAttrs& attrs,
const std::vector<NDArray>& outputs) {
using namespace mshadow;
using namespace mxnet_op;
+ using red::limits::MaxValue;
+ using red::limits::MinValue;
typedef int32_t SrcDType;
typedef int8_t DstDType;
Review comment:
This can be removed, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services