[GitHub] [hbase] ZhaoBQ commented on a change in pull request #2742: HBASE-25365 The log in move_servers_rsgroup is incorrect

[GitBox <gi...@apache.org>]

ZhaoBQ commented on a change in pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#discussion_r543456800



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1015,17 +1016,17 @@ private void moveServerRegionsFromGroup(Set<Address> movedServers, Set<Address>
               assignmentFutures.add(Pair.newPair(region, future));
             } catch (IOException ioe) {
               failedRegions.add(region.getRegionNameAsString());
-              LOG.debug("Move region {} from group failed, will retry, current retry time is {}",
-                region.getShortNameToLog(), retry, ioe);
+              LOG.debug("Move region {} from server {} failed, will retry, current retry time is {}",
+                region.getShortNameToLog(), owner.getHostname(), retry, ioe);
               toThrow = ioe;
             }
           }
         }
       }
-      waitForRegionMovement(assignmentFutures, failedRegions, targetGrp.getName(), retry);
+      waitForRegionMovement(assignmentFutures, failedRegions, sourceGroupName, retry);
       if (failedRegions.isEmpty()) {
-        LOG.info("All regions from server(s) {} moved to target group {}.", movedServerNames,
-          targetGrp.getName());
+        LOG.info("All regions from server(s) {} moved to source group {}.", movedServerNames,

Review comment:
       The regions in movedServerNames originally belongs to the source group. So it should not say "move from sourceGroupName to targetGroupName". Maybe it can be like this: “All regions from {} are moved back to {}, movedServerNames, sourceGroupName”?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org