You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2010/10/15 16:50:51 UTC

DO NOT REPLY [Bug 50098] New: AFP Renderer: Minor border Painting Inconsistencies

https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

           Summary: AFP Renderer: Minor border Painting Inconsistencies
           Product: Fop
           Version: all
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: general
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: med1985@gmail.com


Because AFP doesn't use floating point numbers to define x,y co-ordinates (like
PDF and PS) there are rounding error that cause border inconsistencies.
However, because (I presume) most borders are very thin, they are barely
visible. This issue became apparent when fixing Bug# 15368.

When using dashed borders, this issue is much more visible since it manifests
in non-squared borders i.e. there are white-spaces in corners rather than
proper squared borders.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #5 from Mehdi Houshmand <me...@gmail.com> 2012-04-10 08:50:44 UTC ---
Well, because I could append the original FO but that would only show a subset
of the problem. The issue is a systemic one, concerning how floating point
numbers are handled, or not handled as the case may be in some cases, in the
AFP rendering system.

Coincidentally r1311638, which I've just applied also addresses one of many
symptoms of this problem. But this issue isn't present and wouldn't have been
noticed when this problem was initially recognised. If you are demanding an FO;
playing with Bug#45822 would be sufficient, but again this is only subset of
the symptoms.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #3 from Mehdi Houshmand <me...@gmail.com> 2012-04-09 19:02:49 UTC ---
This doesn't require a single FO to demonstrate the point, it was more of a
marker for illustrating a flaw in how the AFP rendering works. The AFP painter
does a lot of arithmetic and the floating-point -> integer conversion happens
too early, magnifying rounding errors.

As always, this just needs time... Sorry if that isn't very helpful

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

--- Comment #2 from Glenn Adams <gl...@skynav.com> 2012-04-09 18:55:10 UTC ---
please provide a test input FO file and an image of currently produced AFP (for
those of us who don't have access to an AFP output device

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #8 from Luis Bernardo <lm...@gmail.com> ---
Created attachment 28792
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28792&action=edit
test *.afp output

-- 
You are receiving this mail because:
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #4 from Glenn Adams <gl...@skynav.com> 2012-04-09 19:15:22 UTC ---
(In reply to comment #3)
> This doesn't require a single FO to demonstrate the point, it was more of a
> marker for illustrating a flaw in how the AFP rendering works. The AFP painter
> does a lot of arithmetic and the floating-point -> integer conversion happens
> too early, magnifying rounding errors.
> 
> As always, this just needs time... Sorry if that isn't very helpful

when someone gets around to looking at this, it will be important to have a
test file that demonstrates the problem; i don't see why you can't construct
such a test file

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #1 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:42:11 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #6 from Glenn Adams <ga...@apache.org> 2012-04-24 05:51:37 UTC ---
(In reply to comment #5)
> Well, because I could append the original FO but that would only show a subset
> of the problem. The issue is a systemic one, concerning how floating point
> numbers are handled, or not handled as the case may be in some cases, in the
> AFP rendering system.
> 
> Coincidentally r1311638, which I've just applied also addresses one of many
> symptoms of this problem. But this issue isn't present and wouldn't have been
> noticed when this problem was initially recognised. If you are demanding an FO;
> playing with Bug#45822 would be sufficient, but again this is only subset of
> the symptoms.

yes, i'm asking for a minimal input FO, an output PDF, and any relevant console
log;

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50098] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50098

--- Comment #7 from Luis Bernardo <lm...@gmail.com> ---
Created attachment 28791
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28791&action=edit
test *.fo file

-- 
You are receiving this mail because:
You are the assignee for the bug.