You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2018/12/27 15:30:48 UTC
carbondata git commit: [HOTFIX] rename field thread_pool_size to
match camel case
Repository: carbondata
Updated Branches:
refs/heads/master 56aecb6b6 -> d5a2c698c
[HOTFIX] rename field thread_pool_size to match camel case
This closes #3018
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/d5a2c698
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/d5a2c698
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/d5a2c698
Branch: refs/heads/master
Commit: d5a2c698c274cf752e48f3a2709314c460d22264
Parents: 56aecb6
Author: lamber-ken <22...@qq.com>
Authored: Sun Dec 23 23:52:15 2018 +0800
Committer: Jacky Li <ja...@qq.com>
Committed: Thu Dec 27 23:30:33 2018 +0800
----------------------------------------------------------------------
.../core/cache/dictionary/AbstractDictionaryCache.java | 4 ++--
.../carbondata/core/cache/dictionary/ForwardDictionaryCache.java | 2 +-
.../carbondata/core/cache/dictionary/ReverseDictionaryCache.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/d5a2c698/core/src/main/java/org/apache/carbondata/core/cache/dictionary/AbstractDictionaryCache.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/cache/dictionary/AbstractDictionaryCache.java b/core/src/main/java/org/apache/carbondata/core/cache/dictionary/AbstractDictionaryCache.java
index 36d5f98..067f344 100644
--- a/core/src/main/java/org/apache/carbondata/core/cache/dictionary/AbstractDictionaryCache.java
+++ b/core/src/main/java/org/apache/carbondata/core/cache/dictionary/AbstractDictionaryCache.java
@@ -43,7 +43,7 @@ public abstract class AbstractDictionaryCache<K extends DictionaryColumnUniqueId
/**
* thread pool size to be used for dictionary data reading
*/
- protected int thread_pool_size;
+ protected int threadPoolSize;
/**
* LRU cache variable
@@ -70,7 +70,7 @@ public abstract class AbstractDictionaryCache<K extends DictionaryColumnUniqueId
* max number of threads for a job
*/
private void initThreadPoolSize() {
- thread_pool_size = CarbonProperties.getInstance().getNumberOfLoadingCores();
+ threadPoolSize = CarbonProperties.getInstance().getNumberOfLoadingCores();
}
/**
http://git-wip-us.apache.org/repos/asf/carbondata/blob/d5a2c698/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ForwardDictionaryCache.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ForwardDictionaryCache.java b/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ForwardDictionaryCache.java
index 1607f0f..dad6c8f 100644
--- a/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ForwardDictionaryCache.java
+++ b/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ForwardDictionaryCache.java
@@ -97,7 +97,7 @@ public class ForwardDictionaryCache<K extends
new ArrayList<Dictionary>(dictionaryColumnUniqueIdentifiers.size());
List<Future<Dictionary>> taskSubmitList =
new ArrayList<>(dictionaryColumnUniqueIdentifiers.size());
- ExecutorService executorService = Executors.newFixedThreadPool(thread_pool_size);
+ ExecutorService executorService = Executors.newFixedThreadPool(threadPoolSize);
for (final DictionaryColumnUniqueIdentifier uniqueIdent : dictionaryColumnUniqueIdentifiers) {
taskSubmitList.add(executorService.submit(new Callable<Dictionary>() {
@Override public Dictionary call() throws IOException {
http://git-wip-us.apache.org/repos/asf/carbondata/blob/d5a2c698/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java b/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
index deb7339..f40b611 100644
--- a/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
+++ b/core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
@@ -103,7 +103,7 @@ public class ReverseDictionaryCache<K extends DictionaryColumnUniqueIdentifier,
new ArrayList<Dictionary>(dictionaryColumnUniqueIdentifiers.size());
List<Future<Dictionary>> taskSubmitList =
new ArrayList<>(dictionaryColumnUniqueIdentifiers.size());
- ExecutorService executorService = Executors.newFixedThreadPool(thread_pool_size);
+ ExecutorService executorService = Executors.newFixedThreadPool(threadPoolSize);
for (final DictionaryColumnUniqueIdentifier uniqueIdent : dictionaryColumnUniqueIdentifiers) {
taskSubmitList.add(executorService.submit(new Callable<Dictionary>() {
@Override public Dictionary call() throws IOException {