You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/30 17:07:00 UTC

[jira] [Commented] (GEODE-6674) Put65 has unneeded allocation of StringBuilder

    [ https://issues.apache.org/jira/browse/GEODE-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830476#comment-16830476 ] 

ASF subversion and git services commented on GEODE-6674:
--------------------------------------------------------

Commit 52abb90845a5afa8660a24cad2d61214310ffc3d in geode's branch refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=52abb90 ]

GEODE-6674: only create StringBuilder if needed (#3511)

* added unit tests for Put65 when region or key are null

* no longer allocates a StringBuilder for every client put message


> Put65 has unneeded allocation of StringBuilder
> ----------------------------------------------
>
>                 Key: GEODE-6674
>                 URL: https://issues.apache.org/jira/browse/GEODE-6674
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: performance
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Put65 message processing always creates a new StringBuilder even if it does not use it. It would be easy to change it to only create the StringBuilder when it needs to format an error message. The unneeded instance is stored in "errMessage".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)