[GitHub] [rocketmq] li-xiao-shuang commented on a diff in pull request #4258: [Polish] Optimized code

[GitBox <gi...@apache.org>]

li-xiao-shuang commented on code in PR #4258:
URL: https://github.com/apache/rocketmq/pull/4258#discussion_r867464334


##########
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java:
##########
@@ -417,7 +417,7 @@ public void createTopic(String key, String newTopic, int queueNum) throws MQClie
     @Override
     public void setUseTLS(boolean useTLS) {
         super.setUseTLS(useTLS);
-        if (traceDispatcher != null && traceDispatcher instanceof AsyncTraceDispatcher) {

Review Comment:
   > IMO,Null is not an instanceof anything, so a null check is redundant.
   
   Agree with



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org