You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "geserdugarov (via GitHub)" <gi...@apache.org> on 2025/01/14 05:22:33 UTC

[PR] [MINOR] Automatic activation of `java17` profile [hudi]

geserdugarov opened a new pull request, #12630:
URL: https://github.com/apache/hudi/pull/12630

   To check CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2820514250

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058",
       "triggerID" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40064fcf3984b595324630bf8c99e243a0617646 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838) 
   * 86339bffee77ec25dacd6e5f6fd7ecb7bc16457d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r2053674804


##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
           SPARK_MODULES: ${{ matrix.sparkModules }}
         run:
-          mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl "hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS

Review Comment:
   If we decide to switch to automatic `java17` detection, then here we check that these detection actually happened. Otherwise, if `java17` profile hasn't applied automatically, then we should get errors related to missed set of JVM parameters like `--add-opens=java.base/java.lang=ALL-UNNAMED ...`. Explicit set of JDK version will hide these issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2820510451

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40064fcf3984b595324630bf8c99e243a0617646 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838) 
   * 86339bffee77ec25dacd6e5f6fd7ecb7bc16457d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2821206199

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058",
       "triggerID" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5061",
       "triggerID" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f5386bf9faff32acd914f4424e23a400aa3c50e8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5061) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2820671713

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058",
       "triggerID" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5061",
       "triggerID" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 86339bffee77ec25dacd6e5f6fd7ecb7bc16457d Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058) 
   * f5386bf9faff32acd914f4424e23a400aa3c50e8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5061) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r1914647095


##########
pom.xml:
##########
@@ -2633,14 +2633,14 @@
 
     <profile>
       <id>java17</id>
+      <activation>
+        <jdk>[17,)</jdk>
+      </activation>
       <properties>
+        <!-- to check during compilation that we didn't use APIs that don't exist in previous releases, remove after drop support of JDK 8 -->
+        <maven.compiler.release>8</maven.compiler.release>

Review Comment:
   This was done corresponding to Maven doc:
   https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
   We have maven-compiler-plugin 3.8.0, so it's enough to set property `maven.compiler.release`.
   And we need to use `release` option to check that we didn't break any APIs from previous Java releases. Also, there is a lot of confusion around `source`, `target`, and `release`. For this reason there are corresponding changes in JDK:
   https://bugs.openjdk.org/browse/JDK-8308399



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov closed pull request #12630: [MINOR] Automatic activation of `java17` profile
URL: https://github.com/apache/hudi/pull/12630


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r1914647095


##########
pom.xml:
##########
@@ -2633,14 +2633,14 @@
 
     <profile>
       <id>java17</id>
+      <activation>
+        <jdk>[17,)</jdk>
+      </activation>
       <properties>
+        <!-- to check during compilation that we didn't use APIs that don't exist in previous releases, remove after drop support of JDK 8 -->
+        <maven.compiler.release>8</maven.compiler.release>

Review Comment:
   This was done corresponding to Maven doc:
   https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
   We have maven-compiler-plugin 3.8.0, so it's enough to set property `maven.compiler.release`.
   And we need to use `release` option to check that we didn't use APIs that don't exist in previous Java releases.
   Also, there is a lot of confusion around `source`, `target`, and `release`. For this reason corresponding changes in JDK has been done:
   https://bugs.openjdk.org/browse/JDK-8308399



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2820559606

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058",
       "triggerID" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 86339bffee77ec25dacd6e5f6fd7ecb7bc16457d Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058) 
   * f5386bf9faff32acd914f4424e23a400aa3c50e8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r2053631351


##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
           SPARK_MODULES: ${{ matrix.sparkModules }}
         run:
-          mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl "hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS

Review Comment:
   why remove the explicit jdk version?



##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
           SPARK_MODULES: ${{ matrix.sparkModules }}
         run:
-          mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl "hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS

Review Comment:
   why remove the explicit jdk version?



##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
           SPARK_MODULES: ${{ matrix.sparkModules }}
         run:
-          mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl "hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS

Review Comment:
   why remove the explicit jdk version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2590310098

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 40064fcf3984b595324630bf8c99e243a0617646 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833) Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2589649116

   @yihua , if you don't mind, could you, please, check proposed changes. You made a lot of work related to Hudi CI. It would be great to know your opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2589980698

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2590622678

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 40064fcf3984b595324630bf8c99e243a0617646 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r2055080631


##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
           SPARK_MODULES: ${{ matrix.sparkModules }}
         run:
-          mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl "hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS

Review Comment:
   @yihua Can you confirm this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-3082874480

   Close due to no updates for a long time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2820556115

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     }, {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838",
       "triggerID" : "2589980698",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058",
       "triggerID" : "86339bffee77ec25dacd6e5f6fd7ecb7bc16457d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f5386bf9faff32acd914f4424e23a400aa3c50e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40064fcf3984b595324630bf8c99e243a0617646 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2833) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2838) 
   * 86339bffee77ec25dacd6e5f6fd7ecb7bc16457d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5058) 
   * f5386bf9faff32acd914f4424e23a400aa3c50e8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r2053674804


##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
           SPARK_MODULES: ${{ matrix.sparkModules }}
         run:
-          mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl "hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS

Review Comment:
   If we decide to switch to automatic `java17` detection, then here we check that these detection actually happened. Otherwise, if `java17` profile hasn't applied automatically, then we should get errors related to missed set of JVM parameters like `--add-opens=java.base/java.lang=ALL-UNNAMED ...`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2589030725

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40064fcf3984b595324630bf8c99e243a0617646",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "40064fcf3984b595324630bf8c99e243a0617646",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40064fcf3984b595324630bf8c99e243a0617646 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Automatic activation of `java17` profile [hudi]

Posted by "geserdugarov (via GitHub)" <gi...@apache.org>.
geserdugarov commented on PR #12630:
URL: https://github.com/apache/hudi/pull/12630#issuecomment-2589619906

   Azure CI is successful for this PR:
   https://dev.azure.com/apachehudi/hudi-oss-ci/_build/results?buildId=2833&view=results
   
   Possibly there is some problem with hudi-bot, which leads to not updated status of Azure CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org