You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Nirmal Fernando <ni...@gmail.com> on 2013/12/20 15:20:32 UTC
Re: [5/8] git commit: removing serializability from the network
partitioncontext and partition context since it is not serialized.
Hi Udara,
Are you sure about this? Aren't we persisting these in registry?
On Friday, December 20, 2013, wrote:
> removing serializability from the network partitioncontext and partition
> context since it is not serialized.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/d046aea3
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/d046aea3
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/d046aea3
>
> Branch: refs/heads/master
> Commit: d046aea387c6ae3663b630c16e20b52f6bf1c503
> Parents: 7065a67
> Author: Udara Liyanage <udara@wso2.com <javascript:;>>
> Authored: Fri Dec 20 18:30:00 2013 -0500
> Committer: Udara Liyanage <udara@wso2.com <javascript:;>>
> Committed: Fri Dec 20 19:05:04 2013 -0500
>
> ----------------------------------------------------------------------
> .../org/apache/stratos/autoscaler/NetworkPartitionContext.java | 3 +--
> .../main/java/org/apache/stratos/autoscaler/PartitionContext.java | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/d046aea3/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
> ----------------------------------------------------------------------
> diff --git
> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
> index f5eab01..e902fff 100644
> ---
> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
> +++
> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
> @@ -30,9 +30,8 @@ import java.util.Map;
> * Holds runtime data of a network partition.
> *
> */
> -public class NetworkPartitionContext implements Serializable {
> +public class NetworkPartitionContext{
>
> - private static final long serialVersionUID = -5458149704820463584L;
> private static final Log log =
> LogFactory.getLog(NetworkPartitionContext.class);
> private String id;
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/d046aea3/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
> ----------------------------------------------------------------------
> diff --git
> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
> index 96dc2bd..e60d855 100644
> ---
> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
> +++
> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
> @@ -40,9 +40,8 @@ import java.util.concurrent.CopyOnWriteArrayList;
> *
> */
>
> -public class PartitionContext implements Serializable{
> +public class PartitionContext{
>
> - private static final long serialVersionUID = 5822689534291741272L;
> private static final Log log =
> LogFactory.getLog(PartitionContext.class);
> private String partitionId;
> private String serviceName;
>
>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/
Re: [5/8] git commit: removing serializability from the network
partitioncontext and partition context since it is not serialized.
Posted by Sajith Kariyawasam <sa...@wso2.com>.
On 20 Dec 2013 20:21, "Udara Liyanage" <ud...@wso2.com> wrote:
>
> Oh sorry. I did not see it. This was suggested by find bug.
Each and every suggestion made by find bugs (or checkstyle) may not be
applicable for every project. so the best thing is to come up with a
customized rule set, and use it locally to check for violations before
committing the code. Do we have any templates? Does jenkins integrated with
findbugs.? If so we can use that rule set configured there
> I will fix it
>
>
> On Fri, Dec 20, 2013 at 9:20 AM, Nirmal Fernando <ni...@gmail.com>
wrote:
>>
>> Hi Udara,
>>
>> Are you sure about this? Aren't we persisting these in registry?
>>
>>
>> On Friday, December 20, 2013, wrote:
>>>
>>> removing serializability from the network partitioncontext and
partition context since it is not serialized.
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
>>> Commit:
http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/d046aea3
>>> Tree:
http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/d046aea3
>>> Diff:
http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/d046aea3
>>>
>>> Branch: refs/heads/master
>>> Commit: d046aea387c6ae3663b630c16e20b52f6bf1c503
>>> Parents: 7065a67
>>> Author: Udara Liyanage <ud...@wso2.com>
>>> Authored: Fri Dec 20 18:30:00 2013 -0500
>>> Committer: Udara Liyanage <ud...@wso2.com>
>>> Committed: Fri Dec 20 19:05:04 2013 -0500
>>>
>>> ----------------------------------------------------------------------
>>> .../org/apache/stratos/autoscaler/NetworkPartitionContext.java | 3
+--
>>> .../main/java/org/apache/stratos/autoscaler/PartitionContext.java | 3
+--
>>> 2 files changed, 2 insertions(+), 4 deletions(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>>
http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/d046aea3/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>>> ----------------------------------------------------------------------
>>> diff --git
a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>>> index f5eab01..e902fff 100644
>>> ---
a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>>> +++
b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>>> @@ -30,9 +30,8 @@ import java.util.Map;
>>> * Holds runtime data of a network partition.
>>> *
>>> */
>>> -public class NetworkPartitionContext implements Serializable {
>>> +public class NetworkPartitionContext{
>>>
>>> - private static final long serialVersionUID = -5458149704820463584L;
>>> private static final Log log =
LogFactory.getLog(NetworkPartitionContext.class);
>>> private String id;
>>>
>>>
>>>
http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/d046aea3/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>>> ----------------------------------------------------------------------
>>> diff --git
a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>>> index 96dc2bd..e60d855 100644
>>> ---
a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>>> +++
b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>>> @@ -40,9 +40,8 @@ import java.util.concurrent.CopyOnWriteArrayList;
>>> *
>>> */
>>>
>>> -public class PartitionContext implements Serializable{
>>> +public class PartitionContext{
>>>
>>> - private static final long serialVersionUID = 5822689534291741272L;
>>> private static final Log log =
LogFactory.getLog(PartitionContext.class);
>>> private String partitionId;
>>> private String serviceName;
>>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
Re: [5/8] git commit: removing serializability from the network
partitioncontext and partition context since it is not serialized.
Posted by Udara Liyanage <ud...@wso2.com>.
Oh sorry. I did not see it. This was suggested by find bug.
I will fix it
On Fri, Dec 20, 2013 at 9:20 AM, Nirmal Fernando <ni...@gmail.com>wrote:
> Hi Udara,
>
> Are you sure about this? Aren't we persisting these in registry?
>
>
> On Friday, December 20, 2013, wrote:
>
>> removing serializability from the network partitioncontext and partition
>> context since it is not serialized.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/d046aea3
>> Tree:
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/d046aea3
>> Diff:
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/d046aea3
>>
>> Branch: refs/heads/master
>> Commit: d046aea387c6ae3663b630c16e20b52f6bf1c503
>> Parents: 7065a67
>> Author: Udara Liyanage <ud...@wso2.com>
>> Authored: Fri Dec 20 18:30:00 2013 -0500
>> Committer: Udara Liyanage <ud...@wso2.com>
>> Committed: Fri Dec 20 19:05:04 2013 -0500
>>
>> ----------------------------------------------------------------------
>> .../org/apache/stratos/autoscaler/NetworkPartitionContext.java | 3 +--
>> .../main/java/org/apache/stratos/autoscaler/PartitionContext.java | 3 +--
>> 2 files changed, 2 insertions(+), 4 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/d046aea3/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>> index f5eab01..e902fff 100644
>> ---
>> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>> +++
>> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/NetworkPartitionContext.java
>> @@ -30,9 +30,8 @@ import java.util.Map;
>> * Holds runtime data of a network partition.
>> *
>> */
>> -public class NetworkPartitionContext implements Serializable {
>> +public class NetworkPartitionContext{
>>
>> - private static final long serialVersionUID = -5458149704820463584L;
>> private static final Log log =
>> LogFactory.getLog(NetworkPartitionContext.class);
>> private String id;
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/d046aea3/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>> index 96dc2bd..e60d855 100644
>> ---
>> a/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>> +++
>> b/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/PartitionContext.java
>> @@ -40,9 +40,8 @@ import java.util.concurrent.CopyOnWriteArrayList;
>> *
>> */
>>
>> -public class PartitionContext implements Serializable{
>> +public class PartitionContext{
>>
>> - private static final long serialVersionUID = 5822689534291741272L;
>> private static final Log log =
>> LogFactory.getLog(PartitionContext.class);
>> private String partitionId;
>> private String serviceName;
>>
>>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
>
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897