You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Yun Gao (Jira)" <ji...@apache.org> on 2022/04/13 06:28:07 UTC

[jira] [Updated] (FLINK-15859) Unify identifiers in the interface methods of CatalogManager

     [ https://issues.apache.org/jira/browse/FLINK-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yun Gao updated FLINK-15859:
----------------------------
    Fix Version/s: 1.16.0

> Unify identifiers in the interface methods of CatalogManager
> ------------------------------------------------------------
>
>                 Key: FLINK-15859
>                 URL: https://issues.apache.org/jira/browse/FLINK-15859
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: Dawid Wysakowicz
>            Priority: Minor
>              Labels: auto-deprioritized-major
>             Fix For: 1.15.0, 1.16.0
>
>
> We're not being too consistent with the type of identifier that the FunctionCatalog/CatalogManager accepts.
> Some methods accept {{UnresolvedIdentifier}} e.g. {{FunctionCatalog#registerTemporaryCatalogFunction}}, {{CatalogManager#dropTemporaryView}}. 
> Some resolved {{ObjectIdentifier}} e.g. {{CatalogManager#createTemporaryTable}}, {{CatalogManager#createTable}}.
> I am not sure which one should we prefer. If we go with the {{UnresolvedIdentifier}} the benefit is that we always qualify it in a {{Catalog*}}. The downside is that we would use {{UnresolvedIdentifier}} in {{*Operations}}, (e.g. {{CreateTableOperation}} etc.), whereas we said that all Operations should be fully resolved...



--
This message was sent by Atlassian Jira
(v8.20.1#820001)