You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2015/11/18 19:41:12 UTC
[GitHub] incubator-trafodion pull request: TRAFODION-1635. Changes to a few...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/incubator-trafodion/pull/181
TRAFODION-1635. Changes to a few script related sql message file and to lob startup.
Includes change from Narendra for starting lob process when a node is intergrated.(gensq.pl)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/incubator-trafodion sandhya_traf_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit fd560fbd6eb58e30cefa212a33ed05be17a44800
Author: Sandhya Sundaresan <sa...@apache.org>
Date: 2015-11-18T18:37:26Z
Changes to a few script related sql message file and to lob startup.
Includes change from Narendra for starting lob process when a node is intergrated.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1635. Changes to a few...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/181#discussion_r45414941
--- Diff: core/sqf/sql/scripts/lobstart ---
@@ -30,8 +30,8 @@ let totalNodes=`grep 'Up' $tmp_node_status | wc -l`
while [ ${count} -lt $totalNodes ]
do
sqshell -a > /dev/null << eof
-set {process \zlobsrv${count} } PERSIST_RETRIES=10,60
-set {process \zlobsrv${count} } PERSIST_ZONES=0,1
+set {process \$zlobsrv${count} } PERSIST_RETRIES=10,60
+set {process \$zlobsrv${count} } PERSIST_ZONES=${count}
exec {name \$zlobsrv${count}, nowait, nid ${count}, out stdout_\$ZLOBSRV${count} } mxlobsrvr
--- End diff --
Yes the lob processes will come up when a down node is reintegrated thanks to the change made in gensq.pl. Stylistically it could be better to have the lobstart and the lob config db scripts together. But functionally this setup works just fine. So would prefer not to make further changes to rework this at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1635. Changes to a few...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1635. Changes to a few...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/181#discussion_r45242666
--- Diff: core/sqf/sql/scripts/lobstart ---
@@ -30,8 +30,8 @@ let totalNodes=`grep 'Up' $tmp_node_status | wc -l`
while [ ${count} -lt $totalNodes ]
do
sqshell -a > /dev/null << eof
-set {process \zlobsrv${count} } PERSIST_RETRIES=10,60
-set {process \zlobsrv${count} } PERSIST_ZONES=0,1
+set {process \$zlobsrv${count} } PERSIST_RETRIES=10,60
+set {process \$zlobsrv${count} } PERSIST_ZONES=${count}
exec {name \$zlobsrv${count}, nowait, nid ${count}, out stdout_\$ZLOBSRV${count} } mxlobsrvr
--- End diff --
It looks like this lobstart script attempts to configure and start the lob servers in the nodes which are Up, while the change in sqgen configures it on all nodes. Let's say if we bring the cluster with one node down, the lobstart won't even configure the lob process on that node. When the node is reintegrated, will the lob processes come up. Also, my recommendation would be to configure the lobprocess in sqgen and let sqgen generate the lobstart script. That way, when the cluster is started with node down, the lob process would also be configured for the downed node and flagged as not available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---