You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by eshioji <gi...@git.apache.org> on 2015/07/03 10:12:29 UTC
[GitHub] storm pull request: Storm 763/839 0.10.x
GitHub user eshioji opened a pull request:
https://github.com/apache/storm/pull/617
Storm 763/839 0.10.x
This is a port of PR #568 from 0.9.x to 0.10.x. It fixes STORM-839 (Deadlock) and STORM-763 (Establish Netty reconnects asynchronously and reduce verbosity of error logs)
The content is equivalent to the PR for 0.11.x (#616)
@revans2 This is the PR for 0.10.x. I also ran the performance test for this and the results were again inline with what I got with 0.9.x. I get build failure on my machine but I get the same failure with 0.10.x HEAD, so I'm guessing it's unrelated to this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eshioji/storm STORM-763_0.10.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 286bacdf49937d1e8576eff27dfc887824ffdbbb
Author: Enno Shioji <es...@gmail.com>
Date: 2015-07-02T18:01:01Z
This fixes STORM-763 and STORM-839
commit a2502c3bc3bcd4caf3800bb645058abb61d2a071
Author: Enno Shioji <es...@gmail.com>
Date: 2015-07-02T23:51:32Z
Merge remote-tracking branch 'upstream/0.10.x-branch' into STORM-763_0.10.x
# Conflicts:
# storm-core/src/jvm/backtype/storm/messaging/netty/Client.java
commit f5db06ce2809c3b66f2d797f979f8c40133c2f60
Author: Enno Shioji <es...@gmail.com>
Date: 2015-07-03T00:02:00Z
Bring back removal of client from context on closing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/617#discussion_r35155184
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/StormClientHandler.java ---
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.messaging.netty;
+
+import java.net.ConnectException;
+
+import org.jboss.netty.channel.*;
--- End diff --
Can we not import * in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/617#discussion_r34603263
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -59,20 +59,16 @@
* - Connecting and reconnecting are performed asynchronously.
* - Note: The current implementation drops any messages that are being enqueued for sending if the connection to
* the remote destination is currently unavailable.
- * - A background flusher thread is run in the background. It will, at fixed intervals, check for any pending messages
- * (i.e. messages buffered in memory) and flush them to the remote destination iff background flushing is currently
- * enabled.
*/
public class Client extends ConnectionWithStatus implements IStatefulObject {
+ private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
--- End diff --
It is large, but it matches the code that was there before. This is only used on a close, as a timeout when trying to be sure that we have sent all pending messages. We should look at potentially lowering it, but I think that is for a different JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/617#issuecomment-118503353
FYI, failed build is related to storm-kafka, which is not excluded from 0.10.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/617#discussion_r34599960
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -59,20 +59,16 @@
* - Connecting and reconnecting are performed asynchronously.
* - Note: The current implementation drops any messages that are being enqueued for sending if the connection to
* the remote destination is currently unavailable.
- * - A background flusher thread is run in the background. It will, at fixed intervals, check for any pending messages
- * (i.e. messages buffered in memory) and flush them to the remote destination iff background flushing is currently
- * enabled.
*/
public class Client extends ConnectionWithStatus implements IStatefulObject {
+ private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
--- End diff --
This seems like an incredibly large timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/617#discussion_r34603678
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -59,20 +59,16 @@
* - Connecting and reconnecting are performed asynchronously.
* - Note: The current implementation drops any messages that are being enqueued for sending if the connection to
* the remote destination is currently unavailable.
- * - A background flusher thread is run in the background. It will, at fixed intervals, check for any pending messages
- * (i.e. messages buffered in memory) and flush them to the remote destination iff background flushing is currently
- * enabled.
*/
public class Client extends ConnectionWithStatus implements IStatefulObject {
+ private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
--- End diff --
That's fine with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/617#issuecomment-121338762
+1 the code compiles and the tests all pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/617
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm 763/839 0.10.x
Posted by eshioji <gi...@git.apache.org>.
Github user eshioji commented on a diff in the pull request:
https://github.com/apache/storm/pull/617#discussion_r34602607
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -59,20 +59,16 @@
* - Connecting and reconnecting are performed asynchronously.
* - Note: The current implementation drops any messages that are being enqueued for sending if the connection to
* the remote destination is currently unavailable.
- * - A background flusher thread is run in the background. It will, at fixed intervals, check for any pending messages
- * (i.e. messages buffered in memory) and flush them to the remote destination iff background flushing is currently
- * enabled.
*/
public class Client extends ConnectionWithStatus implements IStatefulObject {
+ private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
--- End diff --
Maybe, this value was inherited from the current code tho. Maybe @miguno can shed light on the rationale?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---