You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/13 18:56:30 UTC

[GitHub] [pulsar-client-go] pgier opened a new pull request, #911: [build] update go version to 1.18

pgier opened a new pull request, #911:
URL: https://github.com/apache/pulsar-client-go/pull/911

   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ### Motivation
   
   Upgrade module golang version from 1.15 to 1.18.  Golang 1.18 is the oldest currently supported version.  See: https://go.dev/doc/devel/release.  Client applications using go 1.15 will still be able to compile against this module, but we should recommend that they upgrade or stick with a previous release, e.g. 0.9.0.
   
   ### Modifications
   
   Updated the golang version in go.mod and ran `go mod tidy`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
     - If a feature is not applicable for documentation, explain why? There are no changes to the API
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911#discussion_r1049890597


##########
README.md:
##########
@@ -36,7 +36,9 @@ CGo based library.
 
 ## Requirements
 
-- Go 1.15+
+- Go 1.18+

Review Comment:
   Why would you append spaces here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] tisonkun commented on pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911#issuecomment-1354104445

   @pgier Thanks for your explanation! I see the IT cases whose matrix includes `1.15` now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] pgier commented on pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
pgier commented on PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911#issuecomment-1354087869

   @tisonkun You are right at that point we will no longer be compatible with go 1.15.  We should see a failure in the 1.15 integration tests at the point when a PR includes an incompatible change, and we would have to either not accept the change, or remove the 1.15 tests.  My point was just that this change by itself doesn't make us incompatible with 1.15.
   
   I'll work on upgrading dependencies next and see if anything fails, and we can decide whether it's worth upgrading specific incompatible deps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] nodece commented on a diff in pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911#discussion_r1049481584


##########
README.md:
##########
@@ -36,7 +36,9 @@ CGo based library.
 
 ## Requirements
 
-- Go 1.15+
+- Go 1.18+

Review Comment:
   ```suggestion
   - Go 1.18+  
   ```
   
   Should I append two spaces?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] tisonkun commented on pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911#issuecomment-1353854047

   > Client applications using go 1.15 will still be able to compile against this module
   
   @pgier I'm curious about this statement. If we follow write some code depending on new added APIs, how can a lib compile in 1.15 compile with us as a dependency? Said `os.ReadFile`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] tisonkun commented on a diff in pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911#discussion_r1050320212


##########
README.md:
##########
@@ -36,7 +36,9 @@ CGo based library.
 
 ## Requirements
 
-- Go 1.15+
+- Go 1.18+
+  Note that while this library should work with golang versions as early as go 1.15,
+  any bugs specific to Golang versions earlier than Go 1.18 may not be fixed.

Review Comment:
   ```suggestion
   
   > **Note**:
   >
   > While this library should work with Golang versions as early as 1.15, any bugs specific to versions earlier than 1.18 may not be fixed.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] nodece merged pull request #911: [build] update go version to 1.18

Posted by GitBox <gi...@apache.org>.
nodece merged PR #911:
URL: https://github.com/apache/pulsar-client-go/pull/911


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org