You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ku...@apache.org on 2018/08/02 12:19:42 UTC
carbondata git commit: [CARBONDATA-2812] Implement freeMemory for
complex pages
Repository: carbondata
Updated Branches:
refs/heads/master a2928e314 -> f2e898ac5
[CARBONDATA-2812] Implement freeMemory for complex pages
Problem:
The memory used by the ColumnPageWrapper (for complex data types) is not
cleared and so it requires more memory to Load and Query.
Solution:
Clear the used memory in the freeMemory method.
This closes #2599
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/f2e898ac
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/f2e898ac
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/f2e898ac
Branch: refs/heads/master
Commit: f2e898ac585458b6c99e08c8fac0e47bec93fee0
Parents: a2928e3
Author: dhatchayani <dh...@gmail.com>
Authored: Thu Aug 2 08:30:32 2018 +0530
Committer: kunal642 <ku...@gmail.com>
Committed: Thu Aug 2 17:49:26 2018 +0530
----------------------------------------------------------------------
.../core/datastore/chunk/store/ColumnPageWrapper.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/f2e898ac/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java b/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
index 180b3a2..a5d5917 100644
--- a/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
+++ b/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
@@ -163,7 +163,10 @@ public class ColumnPageWrapper implements DimensionColumnPage {
@Override
public void freeMemory() {
-
+ if (null != columnPage) {
+ columnPage.freeMemory();
+ columnPage = null;
+ }
}
public boolean isAdaptiveComplexPrimitive() {